New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribution reservation uses a global system lock even when domains are enabled. #5143

Open

gerrod3 opened this issue Mar 21, 2024 · 0 comments

Labels

Issue

Contributor

gerrod3 commented Mar 21, 2024

Version
<3.50

Describe the bug
Reservation code for distributions does not take account if domains are enabled, thus taking a system wide lock: https://github.com/pulp/pulpcore/blob/main/pulpcore/app/viewsets/publication.py#L546
It should match what replicate does: https://github.com/pulp/pulpcore/blob/main/pulpcore/app/replica.py#L43
The mismatch between the two can also cause incorrect behavior as the locks won't match up.

gerrod3 added Issue Triage-Needed labels

mdellweg mentioned this issue

Fix replicate for a distribution with publication #5140

Merged

dkliban removed the Triage-Needed label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment