Use an actual bracket to handle test setup/cleanup

[jy14898]

At the moment, cleanup is handled by simply running the cleanup after the test sub-tree:

purescript-spec/src/Test/Spec/Runner.purs

Line 132 in f0661f0

loop (mapWithIndex indexer xs) <* lift (cleanup unit)

This isn't great, as it doesn't get run in situations where the Aff was cancelled. We can fix this by using Aff's bracket.

IMO this would also lead to a simpler implementation of the afterAll beforeAll hook if a full bracket is encoded in the tree data type

[JordanMartinez]

Mind exploring this idea in a PR?

[JordanMartinez]

😅 Then again, I don't have write-access to this repo, so I couldn't merge such a PR anyway.

[jy14898]

Smallest change would be to do:

- loop (mapWithIndex indexer xs) <* lift (cleanup unit)
+ bracket
+   (pure unit)
+   cleanup
+   (const $ loop $ mapWithIndex indexer xs)

But that wouldn't include simplifying beforeAll. I had a proof of concept for work, but I don't think it's in any usable state now (and based off an old version of purescript-spec).

I may take a look again when I have time

[fsoikin]

I can merge a PR @JordanMartinez if one is presented.