Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise more tests under gevent/eventlet #591

Open
ztzg opened this issue Feb 24, 2020 · 0 comments
Open

Exercise more tests under gevent/eventlet #591

ztzg opened this issue Feb 24, 2020 · 0 comments

Comments

@ztzg
Copy link
Contributor

ztzg commented Feb 24, 2020

The number of tests run under eventlet and gevent (in addition to the standard threading) is limited to a few classes:

TestEventletClient(test_client.TestClient)
TestEventletSemaphore(test_lock.TestSemaphore)
TestEventletLock(test_lock.KazooLockTests)

TestGeventClient(test_client.TestClient)

Extending the coverage is not a simple matter of adding more subclasses, as some tests (e.g., in test_connection.TestConnectionHandler) rely on primitives such as threading.Event and time.sleep. These first have to be replaced by the appropriate handler-specific implementations.

This ticket is about doing both.

See #588 (comment) for the discussion which led to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant