This repository has been archived by the owner on Jun 14, 2020. It is now read-only.
fixed issue with modal stealing focus even after it is destroyed #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craga89
added a commit
that referenced
this pull request
Dec 14, 2012
fixed issue with modal stealing focus even after it is destroyed
Craga89
added a commit
that referenced
this pull request
Dec 14, 2012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When modal qtip is destroyed (for example when it's trigger element is removed from DOM), it doesn't stop stealing focus. I think that the reason is that the event handler is bound using bind, and destroy tries to unbind it using undelegate.
Simple reproduction:
http://jsbin.com/ixodon/1/edit
And with this fix applied:
http://jsbin.com/urorof/1/edit