You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Good suggestion. libqhull_r.h defines qh_True for users who want to avoid using 'True' in their code.
Since a rename affects almost all files and would break existing code, this change will be considered for the next release (hopefully some time next year).
Hello,
The preprocessor defines in:
qhull/src/libqhull_r/libqhull_r.h
Line 117 in 013e325
can cause problems with other libraries, as
True
andFalse
are pretty common tokens (e.g., see https://github.com/stevenlovegrove/Pangolin/blob/master/components/pango_core/include/pangolin/utils/true_false_toggle.h).If these are truly needed, would it be possible to have them renamed to something less likely to cause unwanted interactions?
Thanks!
The text was updated successfully, but these errors were encountered: