Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default for actionlinks() false #403

Open
George9000 opened this issue Jun 25, 2021 · 2 comments
Open

Make default for actionlinks() false #403

George9000 opened this issue Jun 25, 2021 · 2 comments

Comments

@George9000
Copy link

One of the actionlinks shown in the ellipsis button after VegaLite generates a figure in the browser is "Edit in Vega editor." Since this reaches out to https://vega.github.io/editor/#/ with the current figure and all data associated with it in the JSON spec passed to the editor, it poses a risk for those working with sensitive data. Apparently this data is kept client side only in the browser. However, it is better that someone working with the figure consider the potential risk and choose this option actively rather than misconstrue that the editor is local, when it is querying an external URL. So make actionlinks(false) the default in the package.

@davidanthoff
Copy link
Member

I think we should probably just adopt Preferences.jl for something like that and make this a user configurable setting?

@George9000
Copy link
Author

I wasn't aware of Preferences.jl. That seems promising for a default setting. Is that too much overhead to change one setting though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants