Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$.rails undefined with jquery 3.4.0 #515

Open
phoet opened this issue Apr 23, 2019 · 10 comments
Open

$.rails undefined with jquery 3.4.0 #515

phoet opened this issue Apr 23, 2019 · 10 comments

Comments

@phoet
Copy link

phoet commented Apr 23, 2019

our automated @depfu yarn updates had some errors in our system-tests.

with jquery 3.4.0 there are some problems with jquery-ujs and other libraries such as bootstrap-datepicker.

i'm not completely sure what is happening there. just leaving this here in case anyone else finds related issues.

@phoet
Copy link
Author

phoet commented Apr 23, 2019

it looks like this is because of yarnpkg/yarn#4125

it looks like it got fixed here, but i assume no new version has been released to NPM?

Screen Shot 2019-04-23 at 16 01 35

@phoet
Copy link
Author

phoet commented Apr 24, 2019

@theflow 👀 i guess that there will be many issues that like that with your js builds

@phoet
Copy link
Author

phoet commented Apr 24, 2019

@rafaelfranca could you take a look and verify that this will need a new npm release? thx!

@phoet
Copy link
Author

phoet commented May 6, 2019

@lucasmazza do you know who can be asked about releasing a new npm version of this?

@phoet
Copy link
Author

phoet commented May 15, 2019

😿

@lucasmazza
Copy link
Contributor

☝️ ping @rafaelfranca

@klaustopher
Copy link

@phoet hitting the same issue, have you found any workarounds?

@phoet
Copy link
Author

phoet commented Jul 25, 2019

@klaustopher editing the yarn.lock by hand...

@klaustopher
Copy link

Hmm, ok .. I'd like to run the jquery update but if this is not possible, then we might need to always stay on 3.3.x ☹️

@phoet
Copy link
Author

phoet commented Jul 25, 2019

It is possible, just yarn thinks it should use different versions for your dependencies. If you update and them merge both dependencies in your yarn.lock everything works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants