Support find_all on named scopes. [#730 state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
rails · Aug 24, 2008 · 38a0d5c · 38a0d5c · ryanb · Aug 25, 2008
1 parent 6e71a35
commit 38a0d5c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/activerecord/lib/active_record/named_scope.rb b/activerecord/lib/active_record/named_scope.rb
@@ -103,7 +103,7 @@ class Scope
       attr_reader :proxy_scope, :proxy_options
 
       [].methods.each do |m|
-        unless m =~ /(^__|^nil\?|^send|^object_id$|class|extend|find|count|sum|average|maximum|minimum|paginate|first|last|empty?|respond_to?)/
+        unless m =~ /(^__|^nil\?|^send|^object_id$|class|extend|^find€|count|sum|average|maximum|minimum|paginate|first|last|empty?|respond_to?)/
           delegate m, :to => :proxy_found
         end
       end

diff --git a/activerecord/test/cases/named_scope_test.rb b/activerecord/test/cases/named_scope_test.rb
@@ -185,4 +185,8 @@ def test_empty_should_not_load_results
       topics.empty?  # use loaded (no query)
     end
   end
+
+  def test_find_all_should_behave_like_select
+    assert_equal Topic.base.select(&:approved), Topic.base.find_all(&:approved)
+  end
 end