-
Notifications
You must be signed in to change notification settings - Fork 21.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cut down even further on rake -T noise
- Loading branch information
Showing
4 changed files
with
91 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9838156
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One man's noise is another man's documentation. I don't mind the re-wording but removing docs to often used tasks (such as db:migrate:redo) seems odd. It means I can no longer tell other developers to "run rake -T" and read the docs.
Is there a good online places these now hidden rake tasks are documented. Maybe the Rails guides? Or is this now a hidden feature for those in the know? Just my two cents.
9838156
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhh to reduce noise we can aways use
grep
... It would be nice to have all tasks documented with descriptions again.9838156
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has not improved my life, or my developers'; since the implication (to me) is that undescribed Rake tasks are not part of ActiveRecord's public API, I just find it confusing. Respectfully ask you and the core team to please reconsider.
9838156
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gbuesing you can still consider the same rake tasks as public, as they were before. It's just that now the most common used tasks show up, and you can always use
rake -T --all
to show everything, no matter whether they have description or not.