attr_accessor_with_default should raise an ArgumentError not a Runtim…

…eError
rails · Sep 24, 2010 · a0db7be · a0db7be
1 parent a348ffc
commit a0db7be
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/activesupport/lib/active_support/core_ext/module/attr_accessor_with_default.rb b/activesupport/lib/active_support/core_ext/module/attr_accessor_with_default.rb
@@ -18,9 +18,8 @@ class Module
   #
   #   attr_accessor_with_default(:element_name) { name.underscore }
   #
-  def attr_accessor_with_default(sym, default = nil, &block)
-    raise 'Default value or block required' unless !default.nil? || block
-    define_method(sym, block_given? ? block : Proc.new { default })
+  def attr_accessor_with_default(sym, default = Proc.new)
+    define_method(sym, block_given? ? default : Proc.new { default })
     module_eval(<<-EVAL, __FILE__, __LINE__ + 1)
       def #{sym}=(value)                        # def age=(value)
         class << self; attr_reader :#{sym} end  #   class << self; attr_reader :age end

diff --git a/activesupport/test/core_ext/module/attr_accessor_with_default_test.rb b/activesupport/test/core_ext/module/attr_accessor_with_default_test.rb
@@ -26,6 +26,6 @@ def test_default_proc
   end
 
   def test_invalid_args
-    assert_raise(RuntimeError) {@target.attr_accessor_with_default :foo}
+    assert_raise(ArgumentError) {@target.attr_accessor_with_default :foo}
   end
 end