config.assets.logger not working

[mdi]

Setting config.assets.logger = false doesn't seem to work as advertised. When set, I still see sprockets asset logging.

[guilleiguaran]

Can you put an example of your logs?

[mdi]

Completed 200 OK in 911ms (Views: 408.0ms | ActiveRecord: 105.0ms)


Started GET "/assets/bootstrap.css?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/formtastic-bootstrap.css?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/jquery-ui.css?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/jquery.tagsinput.css?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/jquery.timepicker.css?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/application.css?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/locales/jquery.ui.datepicker-en.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/jquery_ujs.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/autocomplete-rails.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/bootstrap-alerts.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/bootstrap-dropdown.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/bootstrap-tabs.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/jail.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/jquery.isotope.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/jquery.livequery.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/jquery.tagsinput.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/jquery.timepicker.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/showdown.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/wmd.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/string.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/application.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/spin.gif" for 127.0.0.1 at 2012-01-20 23:16:46 -0500


Started GET "/assets/icons.png" for 127.0.0.1 at 2012-01-20 23:16:47 -0500

[mdi]

Looking closer at the logs, it seems it gets rid of the calls like:

Served asset /jquery.isotope.js - 304 Not Modified (0ms)

But what about the calls like:

Started GET "/assets/jquery.isotope.js?body=1" for 127.0.0.1 at 2012-01-20 23:16:46 -0500

Is that sprockets or something else?

[guilleiguaran]

The Served asset lines and Compiling lines are logged by Sprockets, the Started GET one are logged by ActionPack. config.assets.logger = false only can be used to silent Sprockets logs.

If you want to silent the request logging you can patch Rails::Rack::Logger in an initializer:

Rails::Rack::Logger.class_eval do 
  def call_with_quiet_assets(env)
    previous_level = Rails.logger.level
    Rails.logger.level = Logger::ERROR if env['PATH_INFO'].index("/assets/") == 0 
    call_without_quiet_assets(env).tap do
      Rails.logger.level = previous_level
    end 
  end 
  alias_method_chain :call, :quiet_assets 
end 

For details about why we won't silent the Started GET one read this: #3795 (comment)

[mdi]

Cool. Thanks!

[i5ting]

3.2.13 not working。。。。