Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Rails 7 #52

Open
Overload119 opened this issue Mar 21, 2022 · 1 comment · May be fixed by #53
Open

Support for Rails 7 #52

Overload119 opened this issue Mar 21, 2022 · 1 comment · May be fixed by #53

Comments

@Overload119
Copy link

I ran into this issue:

/Users/amirsharif/.rvm/gems/ruby-2.7.5/gems/activesupport-7.0.2.3/lib/active_support/xml_mini.rb:184:in `current_thread_backend': uninitialized constant ActiveSupport::XmlMini::IsolatedExecutionState (NameError)

When running fontello open after upgrading to Rails 7.

Adding the following line:

require "active_support/isolated_execution_state"

to

/Users/amirsharif/.rvm/gems/ruby-2.7.5/bundler/gems/fontello_rails_converter-2bc7e117256e/lib/fontello_rails_converter.rb

resolved it.

I think we can create a PR for this, I will get around to it if someone can tell me the best way to add it.
@salimhb
Copy link
Member

salimhb commented Mar 22, 2022

Hello @Overload119, nice catch a PR is appreciated 👍

@Overload119 Overload119 linked a pull request Apr 20, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Rails 7 binaryhands/fontello_rails_converter
2 participants
@Overload119 @salimhb