Merge branch 'master' of git@github.com:rakudo/rakudo

rakudo · Feb 26, 2009 · 5e410bb · 5e410bb
2 parents f0a9a5d + 1951708
commit 5e410bb
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 20 deletions.
diff --git a/CREDITS b/CREDITS
@@ -36,6 +36,8 @@ U: Whiteknight
 
 N: Andy Lester
 E: andy@petdance.com
+W: http://perlbuzz.com/
+S: McHenry, IL, USA
 U: petdance
 
 U: ask
@@ -87,7 +89,8 @@ U: cdolan
 D: Rakudo patches
 E: cdolan@cpan.org
 
-N: Chris Fields (cjfields)
+N: Chris Fields
+U: cjfields
 D: Rakudo patches
 
 N: Christoph Otto a.k.a. cotto
@@ -140,7 +143,7 @@ E: francois.perrad@gadz.org
 W: http://fperrad.googlepages.com/home
 U: fperrad
 
-N: Geoff Broadwell (japhb)
+N: Geoff Broadwell
 U: japhb
 E: geoff@broadwell.org
 
@@ -165,10 +168,10 @@ N: Jeff Horwitz
 E: jeff@smashing.org
 U: jhorwitz
 
-N: Jerry Gay a.k.a. particle
+N: Jerry Gay
 U: particle
 E: Jerry.Gay@gmail.com
-S: Seattle, WA
+S: Seattle, WA, USA
 
 N: Jesse Vincent
 U: jesse
@@ -193,7 +196,7 @@ N: Kevin Tew
 U: tewk
 E: tewk@tewk.com
 
-N: Klaas-Jan Stol a.k.a. kj[s]?
+N: Klaas-Jan Stol
 U: kjs
 E: parrotcode@gmail.com
 
@@ -211,7 +214,7 @@ N: Luke Palmer
 E: luke@luqui.org
 U: luqui
 
-N: Mark Glines a.k.a. Infinoid
+N: Mark Glines
 U: infinoid
 E: mark@glines.org
 S: South Lake Tahoe, CA, USA

diff --git a/build/Makefile.in b/build/Makefile.in
@@ -175,7 +175,7 @@ testable : perl6$(EXE) Test.pir spectest_checkout spectest_update
 
 xmas: perl6$(EXE)
 
-CRITIC_FILES=Configure.pl t/harness build/ config/ tools/
+CRITIC_FILES=Configure.pl t/harness build/ tools/
 
 perlcritic:
 	perlcritic -1 --profile tools/util/perlcritic.conf $(CRITIC_FILES)

diff --git a/build/gen_junction_pir.pl b/build/gen_junction_pir.pl
@@ -50,5 +50,4 @@
     );
 }
 
-close $fh;
-0;
+close $fh or die $!;
diff --git a/t/harness b/t/harness
@@ -2,9 +2,12 @@
 
 # $Id$
 
-# note: du to a limitation in Getopt::Long options that should be passed
+# note: Due to a limitation in Getopt::Long options that should be passed
 # through to fudgeall have to come after all other options
 
+use strict;
+use warnings;
+
 use FindBin;
 use File::Spec;
 use Getopt::Long qw(:config pass_through);
@@ -40,7 +43,7 @@ if ($list_file) {
             warn "Missing test file: $fn\n";
         }
     }
-    close $f;
+    close $f or die $!;
 }
 
 my @tfiles = map { all_in($_) } sort @files;
@@ -57,20 +60,20 @@ sub all_in {
 
     return $start unless -d $start;
 
+    my @skip = ( File::Spec->updir, File::Spec->curdir, qw( .svn CVS .git ) );
+    my %skip = map {($_,1)} @skip;
+
     my @hits = ();
 
-    local *DH;
-    if ( opendir( DH, $start ) ) {
-        my @files = sort readdir DH;
-        closedir DH;
+    if ( opendir( my $dh, $start ) ) {
+        my @files = sort readdir $dh;
+        closedir $dh or die $!;
         for my $file ( @files ) {
-            next if $file eq File::Spec->updir || $file eq File::Spec->curdir;
-            next if $file eq ".svn";
-            next if $file eq "CVS";
+            next if $skip{$file};
 
             my $currfile = File::Spec->catfile( $start, $file );
             if ( -d $currfile ) {
-                push( @hits, all_in( $currfile ) ) if $recurse;
+                push( @hits, all_in( $currfile ) );
             } else {
                 push( @hits, $currfile ) if $currfile =~ /\.t$/;
             }
@@ -84,7 +87,7 @@ sub all_in {
 
 sub fudge {
     my $impl = 'rakudo';
-    my $cmd  = join ' ', $^X, 't/spec/fudgeall', 
+    my $cmd  = join ' ', $^X, 't/spec/fudgeall',
                          @pass_through_options, $impl, @_;
     return split ' ', `$cmd`;
 }