-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore raw_send_recv for module using SMTP mixin #17435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes in rapid7#16153 adjusted modules that were not utilizing `Exploit::Remote::SMTPDeliver` in error restore calls to `raw_send_recv` that is no longer shadowed by in `SMTPDeliver`.
gwillcox-r7
approved these changes
Jan 5, 2023
Before fix:
|
After fix:
|
Release NotesA bug has been fixed whereby some modules were accidentally updated to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17411
Changes in #16153 adjusted modules that were not utilizing
Exploit::Remote::SMTPDeliver
in error. Restore calls toraw_send_recv
that is no longer shadowed by inSMTPDeliver
.Verification