Improve UX for database management prompts #18438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
commented
Oct 9, 2023
| @@ -673,7 +673,7 @@ def persist_data_service | |||
| end | |||
|
|
|||
| def clear_default_data_service | |||
| puts 'Clearing http web data service credentials in msfconsole' | |||
| puts 'Verifying msfconsole data service' | |||
There was a problem hiding this comment.
The old message could suggest to the user that data is being deleted. We still want this message around for debugging user issues - i.e. a crash after this message suggests issues booting msfconsole. We'll go with a more generic verb of 'verify'
adfoster-r7
force-pushed
the
improve-ux-for-database-management-prompts
branch
from
5327030
to
0875cc8
Compare
adfoster-r7
changed the title
|
Everything is working as expected 👍 init
reinit
delete
|
Release NotesMakes improvements to the UX for database management prompts. Now when running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the UX for database management prompts. Now when running
msfdb initthe user is no longer prompted for database deletion. The message for clearing unused data service credentials has been reworded.Verification
msfdb initno longer prompts for the database deletionmsfdb reinitcontinues to prompt for database deletionmsfdb deletecontinues to prompt for database deletion