Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change bloodhound OutputDirectory to OptString #18904

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

double16
Copy link
Contributor

OptPath is intended for a local path and performs validation. Attempting to set it to a target path that doesn't exist on the local fails.

Tell us what this change does. If you're fixing a bug, please mention
the github issue number.

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • use windows/gather/bloodhound
  • set session 1
  • set outputdirectory c:\\windows\\tasks
  • run
image

OptPath is intended for a local path and performs validation. Attempting to set it to a target path that doesn't exist on the local fails.
@adfoster-r7 adfoster-r7 merged commit d4791f9 into rapid7:master Feb 29, 2024
34 checks passed
@adfoster-r7
Copy link
Contributor

Release Notes

Fixes the windows/gather/bloodhound module to no longer incorrectly validate the OutputDirectory option

@adfoster-r7
Copy link
Contributor

Thanks! 👍

@adfoster-r7 adfoster-r7 added the rn-fix release notes fix label Feb 29, 2024
@double16 double16 deleted the patch-1 branch March 1, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants