Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Talend Restlet Framework fingerprint #475

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Add Talend Restlet Framework fingerprint #475

merged 1 commit into from
Sep 16, 2022

Conversation

mkienow-r7
Copy link
Contributor

@mkienow-r7 mkienow-r7 commented Aug 30, 2022 •
edited
Loading

Description

Adds Talend Restlet Framework HTTP server fingerprint.

Motivation and Context

Improved coverage

How Has This Been Tested?

  • bundle exec ./bin/recog_verify xml/http_servers.xml
  • rake tests

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

cbarnard-r7
cbarnard-r7 reviewed Sep 16, 2022
View reviewed changes
xml/http_servers.xml Outdated Show resolved Hide resolved
cbarnard-r7
cbarnard-r7 suggested changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@cbarnard-r7 cbarnard-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you think it's worth changing.

luciddr34m3r
luciddr34m3r approved these changes Sep 16, 2022
View reviewed changes
Copy link

@luciddr34m3r luciddr34m3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cbarnard-r7
cbarnard-r7 approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@cbarnard-r7 cbarnard-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkienow-r7 mkienow-r7 merged commit d9bc8ca into rapid7:main Sep 16, 2022
@mkienow-r7 mkienow-r7 deleted the feature/restlet-framework branch September 16, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luciddr34m3r luciddr34m3r luciddr34m3r approved these changes

@cbarnard-r7 cbarnard-r7 cbarnard-r7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkienow-r7 @luciddr34m3r @cbarnard-r7