Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show progress bar for auto-closing notification #48125

Closed
maifeeulasad opened this issue Mar 27, 2024 · 2 comments · Fixed by react-component/notification#322
Closed

Show progress bar for auto-closing notification #48125

maifeeulasad opened this issue Mar 27, 2024 · 2 comments · Fixed by react-component/notification#322
Labels
Accept You are right, we should do that 💡 Feature Request help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive unconfirmed

Comments

@maifeeulasad
Copy link

What problem does this feature solve?

We have configurations available for setting up the duration for notification(s). But if we do so, it doesn't show any progress when it is going to get closed.

I think, adding a feature to render progress using ant-design's own progress will be great.

What does the proposed API look like?

We can keep the API unmodified, and make it default behavior. Or we can simply add a new field parallel to duration, like this:

...
duration?: number | null;
showProgress: boolean = true // we pass in the default value as well
...

And based on showProgress we render the progress bar for notification(s).
@maifeeulasad
Copy link
Author

I am willing to work on this feature.

@afc163 afc163 added Accept You are right, we should do that 💡 Feature Request help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. labels Mar 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hello @maifeeulasad. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @maifeeulasad，我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支（新特性发到 feature 分支，其他发到 master 分支），务必填写 Pull Request 内的预设模板，提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献。

giphy

This was referenced Apr 5, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accept You are right, we should do that 💡 Feature Request help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive unconfirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(show-progress): add show progress support yociduo/notification
2 participants
@afc163 @maifeeulasad