Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add http-kit profile #46

Open
yogthos opened this issue Mar 23, 2015 · 11 comments
Open

add http-kit profile #46

yogthos opened this issue Mar 23, 2015 · 11 comments

Comments

@yogthos
Copy link
Member

yogthos commented Mar 23, 2015

No description provided.

@piecyk
Copy link

piecyk commented Mar 27, 2015

👍

@mccraigmccraig
Copy link

i took a basic reagent-template app and modified it to work with aleph/manifold... which probably satisfies the same itch you are looking for http-kit to scratch (async, websockets) ?

https://github.com/mccraigmccraig/sparky-elephants

the aleph server doesn't support the :auto-reload? option so i added a ring handler based auto-reload solution :

https://github.com/mccraigmccraig/sparky-elephants/blob/master/env/dev/clj/sparky_elephants/repl.clj

i could port the changes back to an aleph profile in the reagent-template project if you are interested ?

@yogthos
Copy link
Member Author

yogthos commented Apr 30, 2015

there's actually an easier way, you can use ring.middleware.reload as I'm doing in Luminus here.

@mccraigmccraig
Copy link

hmm, iirc i had problems with ring.middleware.reload not re-creating the handler chain, so i modified ring.middleware.reload ( https://github.com/mccraigmccraig/sparky-elephants/blob/master/env/dev/clj/sparky_elephants/wrap_reload.clj ) and then recreate the handler chain on each request

@mccraigmccraig
Copy link

anyway, sounds like you don't need any help with aleph ;)

@yogthos
Copy link
Member Author

yogthos commented Apr 30, 2015

Ah yes I've noticed that as well, route modifications don't get reflected either. I wouldn't mind adding aleph profile as well, just need time. :)

@mccraigmccraig
Copy link

if you would take a PR, i could do an aleph profile in the next few weeks ?

@yogthos
Copy link
Member Author

yogthos commented Apr 30, 2015

that would be fantastic 👍

@mccraigmccraig
Copy link

cool, i'll get on it when i have a moment :)

@alehatsman
Copy link

@mccraigmccraig so have you had a moment since 2015 ?) Does somebody actually interested in this staff ?

@mccraigmccraig
Copy link

@atsman i haven't! i only went and started a new company 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants