Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finish imperative tableview #827

Closed
finnschiermer opened this issue May 13, 2015 · 18 comments
Closed

finish imperative tableview #827

finnschiermer opened this issue May 13, 2015 · 18 comments
Labels
T-Bug-Crash

Comments

@finnschiermer
Copy link
Contributor

No description provided.

@finnschiermer
Copy link
Contributor Author

there is some need for being able to use TableViews in an imperative fashion. The handover stuff has some changes pointing in that direction, but the support is not complete (it was not required to be for handover).

@bmunkholm bmunkholm added the P1 label May 13, 2015
@tgoyne
Copy link
Member

tgoyne commented May 21, 2015

Needed for (or maybe a replacement for) realm/realm-swift#1179 and probably needed for reasonable semantics for realm/realm-swift#687.

@tgoyne tgoyne added the Cocoa label May 21, 2015
@bmunkholm
Copy link
Contributor

Finn: Describe what's left to finish this.

@finnschiermer
Copy link
Contributor Author

TableView::re_sort should eliminate all detached_refs

@finnschiermer finnschiermer mentioned this issue Sep 4, 2015
Merged
@finnschiermer
Copy link
Contributor Author

Querying a tableview with detached refs is undefined. It is tempting to make querying eliminate all detached refs implicitly?

@jpsim
Copy link
Contributor

jpsim commented Dec 10, 2015

@tgoyne is this still a requirement for realm/realm-swift#601 / realm/realm-swift#687?

@tgoyne
Copy link
Member

tgoyne commented Dec 10, 2015

No, the current functionality is sufficient.

@tgoyne tgoyne removed the Cocoa 1.0 label Dec 10, 2015
@finnschiermer
Copy link
Contributor Author

@cmelchior This issue is tagged for android 1.0, but cocoa indicates they do not need it for 1.0. Please reconfirm or clear tag for android 1.0.

@finnschiermer finnschiermer removed their assignment Feb 9, 2016
@cmelchior
Copy link
Contributor

How does aggregate functions like average work on tableviews with detached row accessors in reflective mode if sync_if_needed hasn't been called?

@cmelchior
Copy link
Contributor

cmelchior commented May 11, 2016 •
edited

Realm Java have begun using this and ran into this issue and crash when using TableView::clear when the TableView had detached refs.

I am not sure, but I think @kneth has a unit test that exposes it, so hopefully he can chime in

@cmelchior cmelchior mentioned this issue May 11, 2016
Closed
@finnschiermer
Copy link
Contributor Author

The handling in TableView clear is now tracked as #1803

@kneth
Copy link
Member

kneth commented May 12, 2016

See my branch kg/bug/java-issue-2759.

@danielpovlsen
Copy link
Contributor

Can this be closed?

@kneth
Copy link
Member

kneth commented May 13, 2016

@danielpovlsen I believe so but only @finnschiermer can provide the definite answer.

@finnschiermer
Copy link
Contributor Author

No. It's the users of the feature who will provide the definitive answer. Consider for example sort() on a TableView containing detached refs. Where do the detached refs belong in the sort? before the other items? after? should they be removed all together? stay at the same position? Current decision is to put them after all other entries. Is that the right decision or will it be surprising to some? to too many?

@cmelchior
Copy link
Contributor

People trying to continue manipulating TableViews after they created detached refs, are in most cases asking for trouble anyway.

I would be inclined to think that the current behaviour is fine, at least we haven't heard otherwise. I would close this for now. Any changes to this that are not crashes should be considered feature requests IMO.

@finnschiermer
Copy link
Contributor Author

Exactly. Happy to hear from a user who has now provided the definitive answer. Closing.

@danielpovlsen
Copy link
Contributor

👍

fealebenpae pushed a commit that referenced this issue Nov 17, 2020
Use core's new fifo functions (#827)
9f19d79 
* Use core's new fifo functions
* Remove old <tmp>/realm* files
  Otherwise we will have problem with alternating core-5 and core-6 files.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T-Bug-Crash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@danielpovlsen @cmelchior @tgoyne @jpsim @bmunkholm @kneth @finnschiermer