Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in subset(x cs_min = ...) #97

Open
thibautjombart opened this issue Apr 1, 2019 · 2 comments
Open

Bug in subset(x cs_min = ...) #97

thibautjombart opened this issue Apr 1, 2019 · 2 comments
Labels

Comments

@thibautjombart
Copy link
Contributor

thibautjombart commented Apr 1, 2019

Using this as a placeholder as I cannot share the data leading to the issue and cannot come up with a MRE. When doing plot(subset(x, cs_min = 5)) I end up with a cluster of size 3. Seems to come from NAs in some of the meta-data used for plotting nodes / edge properties. Maybe a cursory look through the subset code with attention to handling of NAs will reveal the issue.

@nistara
Copy link
Member

nistara commented Apr 1, 2019

Hi @thibautjombart , subset_clusters_by_size() doesn't look into NAs, so I'm not sure if that's causing the bug. I added some more checks in the function - if the minimum network cluster size is lesser than specified cs_min it'll stop instead of returning the same network (and a similar check for cs_max and cs). They might help you pinpoint the issue. I should have thought of this scenario earlier!

@nistara
Copy link
Member

nistara commented Apr 1, 2019

Ref issue_97 branch

@nistara nistara mentioned this issue Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants