Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup and improvements #2

Open
tylerhutcherson opened this issue Aug 24, 2023 · 0 comments
Open

Minor cleanup and improvements #2

tylerhutcherson opened this issue Aug 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@tylerhutcherson
Copy link
Collaborator

from @antonum

  • Project ID doesn't need to be secret. Just use input()
  • Don't ask for the region. Just use 'us-central1' as the default
  • Skip user input for table name. Just use hackernews.
  • Add a comment on what public table we are using and how to replace public hackernews with your own.
  • Remove the last cell (!redis-stack-server stop). As is it doesn't work as expected and even an expected shutdown of Redis is not needed here. One can keep playing with the notebook after the "run all" is finished.
  • For the same reasons as above - add a condition for cell 38 (delete tables), so the notebook is still usable for iterative development after "run all".
  • Does it really need to be run on GPU runtime? Consider switching to CPU only.
@tylerhutcherson tylerhutcherson added the enhancement New feature or request label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant