Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix peer dependencies to include future versions #4762

Closed
wants to merge 1 commit into from

Conversation

lynxtaa
Copy link

@lynxtaa lynxtaa commented May 4, 2022

Fixes problems with NPM peer dependencies, including future versions since this package is unmaintained.

Fixes NPM errors when installing react@18 and react-redux@8

Fixes #4763

@lynxtaa
Copy link
Author

lynxtaa commented May 12, 2022

@erikras please merge this PR and release a new version 🙏

@OmerHerera
Copy link

👋 Any idea when this will be merged to the main branch and release
Thanks

@Themonkey180
Copy link

Can we get this merged?
The build issue was only in stable node.
node: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.27' not found (required by node)

@karlbalagtey
Copy link

bump any updates on this

@made-in-nz
Copy link

It's pretty clear this library is no longer maintained. Even it's successor library, final-form/react-final-form is no longer actively maintained. No disrespect to @erikras, I don't think anyone could keep up with the volume of noise these popular libraries generate! IMO this library is better than final-form & others such as formik & react-hook-form so it's a pity.

@ValeriyaKaretnikova
Copy link

Would be great if this PR is merged! Please 🙏

@hvician
Copy link

hvician commented Nov 1, 2022

I wonder when will this be fixed, based on this tread travis-ci.community the version/distribution of Ubuntu Linux that Travis CI runs on needs to be upgraded,{ dist: focal }prop needs to be changed and no changes to travis.yml are required so this is more of a dev ops issue. I wish I had the privs to do the upgrade. The final-form or Formik libraries will never be a replacement of a redux-form as bigger apps need to have access to the form state and form API from various components even if the form component is not mounted.

@jmgarciasanti
Copy link

@erikras please merge this PR because React 17 dependency prevents the evolution to expo SDK 46 which is using React 18
Thanks!

@sbaechler
Copy link

But does Redux Form work with React 18? I guess it won't support concurrent mode.

@jmgarciasanti
Copy link

jmgarciasanti commented Nov 8, 2022

@sbaechler in my case I'm "using" React 18 due to Expo upgrade to SDK 46, but I'm not using React 18 new features like concurrent mode. Maybe dependencies can be upgraded in redux-form to include React 18, with a disclaimer of not supporting concurrent mode at this time.

@efecantekin
Copy link
Contributor

We are still waiting for this pr or alternative solution to be merged. Is there any progress?

@lynxtaa
Copy link
Author

lynxtaa commented Nov 30, 2022

I guess it's not relevant anymore since #4771 is merged

@lynxtaa lynxtaa closed this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support React 18
10 participants