allow optional props with None default value #3179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lendemor
requested changes
Apr 29, 2024
tests/components/test_component.py
Outdated
There was a problem hiding this comment.
Could we also add a test for when the type inside the Optional is a Union ?
There was a problem hiding this comment.
Sure, i'll add more tests later, thanks for your review
benedikt-bartscher
force-pushed
the
optional-component-prop-validation
branch
from
9e66239
to
d08a5a4
Compare
benedikt-bartscher
force-pushed
the
optional-component-prop-validation
branch
from
e5617c0
to
66f7d15
Compare
Lendemor
previously approved these changes
Apr 30, 2024
picklelo
reviewed
May 1, 2024
picklelo
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3158