Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadInlineScript disabled? #24

Open
198d opened this issue Sep 17, 2009 · 1 comment
Open

loadInlineScript disabled? #24

198d opened this issue Sep 17, 2009 · 1 comment
Labels

Comments

@198d
Copy link

198d commented Sep 17, 2009

Specs running on the command line under env.js don't execute inline <script></script> tags in the fixture body. Even if this is supposed to be the default behavior, there should be a way to re-enable inline script loading without modifying test_runner.js. We monkey-patched to fix this issue just by commenting out line 57 in test_runner.js ("loadInlineScript: function(){},").

Looks like there was a recent commit that changed the way test_runner is loading fixtures ( http://github.com/relevance/blue-ridge/commit/7617cd85fb71e5cfe0e6e54d9d8f5281e31079ea ). Just wondering what the rationale behind that particular change was...

@karnowski
Copy link

Hmm, I had just turned that feature off because it was conflicting in some of my tests. I hadn't thought that some folks might be relying on it. You have a great point, though, that this should be configurable. I'm marking this ticket as a feature request for a config option. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants