Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] support for better error message reporting #5

Open
ghost opened this issue May 17, 2009 · 1 comment
Open

[feature] support for better error message reporting #5

ghost opened this issue May 17, 2009 · 1 comment
Labels

Comments

@ghost
Copy link

ghost commented May 17, 2009

original LH ticket

This ticket has 0 attachment(s).

@ghost
Copy link
Author

ghost commented May 17, 2009

[feature] support for better error message reporting

Currently, if you have a TicketResult for alice’s session, you can determine if the cookie is valid, but n/n why it is invalid. Thus it can be difficult to decide whether or not to display TicketResult.message to the user. Perhaps something like Castronaut::Presenters::Login#set_message(ticket_result) could be called by represent!, which would inspect the ticket_result for specific error conditions and set the display message accordingly.

On a different but related note, parsing the error message for info is the method TicketResult uses for determining uses for determining validity, but that doesn’t seem to be a sustainable approach unless there’s going to be a convention for error messages in TicketResult instances.

by Tom Macklin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

0 participants