Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License information removed from artifacts #178

Open
LeoColman opened this issue Mar 24, 2023 · 2 comments
Open

License information removed from artifacts #178

LeoColman opened this issue Mar 24, 2023 · 2 comments

Comments

@LeoColman
Copy link

bfd984e#diff-f89f2cd5186752f47b29318f8846e11017202f20e5e1f8426ee00b1a51ee8868L61-L78

This commit removed some bits that configured SQLite-Android artifact information directly. With this some tools that scan the artifact for licenses are failing to identify sqlite-android as open source.

Identified in:
https://github.com/LeoColman/Petals/actions/runs/4512461828/jobs/7945969326#step:3:135

{
"dependenciesWithoutAllowedLicenses": [
{
"moduleLicense": "",
"moduleVersion": "3.41.1",
"moduleName": "com.github.requery:sqlite-android"
}
]
}

Can we add those info back to the repository so that JitPack can include them?

@npurushe
Copy link
Contributor

Thanks for reporting i'm not sure that is the commit that caused the problem since it only moved the metadata to a different part of the file. I think the with the maven publishing plugin that was added https://github.com/requery/sqlite-android/pull/180/files should be what is needed to resolve it.

@LeoColman
Copy link
Author

LeoColman commented Mar 29, 2023 via email

LeoColman added a commit to LeoColman/Petals that referenced this issue Apr 23, 2023
Related: requery/sqlite-android#172
Related: requery/sqlite-android#178
Related: cashapp/sqldelight#3589
Related: #266
Signed-off-by: Leonardo Colman Lopes <dev@leonardo.colman.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants