Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1 Release Checklist #16

Open
1 of 3 tasks
c-cube opened this issue Mar 2, 2016 · 6 comments
Open
1 of 3 tasks

1.1 Release Checklist #16

c-cube opened this issue Mar 2, 2016 · 6 comments

Comments

@c-cube
Copy link
Collaborator

c-cube commented Mar 2, 2016

I think it's time for a release (either called 1.1 or 2.0, since it seems to breaks some API).

  • use bigstring
  • use result
  • fix test suite
@c-cube
Copy link
Collaborator Author

c-cube commented Mar 2, 2016

Maybe we can migrate to bigstring and result before the release, though

@rgrinberg rgrinberg changed the title release 1.1 1.1 Release Checklist Mar 10, 2016
@c-cube
Copy link
Collaborator Author

c-cube commented Apr 19, 2016

See #17 and #18 . I shoudl also add something to generate the doc and push it on github.

@darioteixeira
Copy link
Collaborator

I've compiled onanomsg 1.0 against the recently released libnanomsg 1.0, and it compiles fine.

I'm getting compilation errors with the current onanomsg master, though. Does master require a different version of ctypes perhaps? (I haven't investigated deeply).

Also, I would be in favour of calling the new release 2.0 because of the API breakage. Semantic versioning makes life a lot easier for everybody downstream...

@darioteixeira
Copy link
Collaborator

Btw, here's the compilation error with current master. I'm not familiar with Ctypes; any idea on what the problem might be?

File "lib_gen/nanomsg_bindings.ml", line 35, characters 43-67:
Error: This expression has type
         (unit -> int) Ctypes.fn = (unit -> int) Ctypes_static.fn
       but an expression was expected of type ('a -> 'b) F.fn

@yallop
Copy link
Contributor

yallop commented Jul 19, 2016

@darioteixeira: there's a fix in #19.

@darioteixeira
Copy link
Collaborator

Thanks @yallop! I've applied your patch on my local repo, and it now compiles fine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants