Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple issues with Ruby 2.0+ #328

Open
weiser opened this issue Aug 12, 2014 · 0 comments
Open

Ripple issues with Ruby 2.0+ #328

weiser opened this issue Aug 12, 2014 · 0 comments

Comments

@weiser
Copy link

weiser commented Aug 12, 2014

$ ruby -v
ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin12.0]

# output of running `bundle exec rake spec` 
639 examples, 5 failures

Failed examples:

rspec /Users/davidann/workspace/ripple/spec/generators/ripple/model_generator_spec.rb:16 # Ripple::Generators::ModelGenerator generating a model with a parent class behaves like subclass_model_generator 
rspec /Users/davidann/workspace/ripple/spec/generators/ripple/model_generator_spec.rb:17 # Ripple::Generators::ModelGenerator generating a model with a parent class behaves like subclass_model_generator 
rspec /Users/davidann/workspace/ripple/spec/ripple/persistence_spec.rb:116 # Ripple::Document::Persistence should reload a saved object, including associations
rspec /Users/davidann/workspace/ripple/spec/ripple/persistence_spec.rb:65 # Ripple::Document::Persistence should instantiate and save a new object to riak
rspec /Users/davidann/workspace/ripple/spec/ripple/persistence_spec.rb:79 # Ripple::Document::Persistence should instantiate and save a new object to riak and allow its attributes to be set via a block

vs ruby 1.9.3:

$ ruby -v
ruby 1.9.3p484 (2013-11-22 revision 43786) [x86_64-darwin13.0.0]

# output from running `bundle exec rake spec`

Failures:

  1) Ripple::Generators::ModelGenerator generating a model with a parent class behaves like subclass_model_generator 
     Failure/Error: it { should_not contain("include Ripple::EmbeddedDocument") }
       expected the file /Users/davidann/workspace/ripple/tmp/app/models/general_model.rb to not contain "include Ripple::EmbeddedDocument" but it did
     Shared Example Group: "subclass_model_generator" called from /Users/davidann/workspace/ripple/spec/generators/ripple/model_generator_spec.rb:51
     # /Users/davidann/workspace/ripple/spec/generators/ripple/model_generator_spec.rb:17:in `block (2 levels) in <top (required)>'

  2) Ripple::Generators::ModelGenerator generating a model with a parent class behaves like subclass_model_generator 
     Failure/Error: it { should_not contain("include Ripple::Document") }
       expected the file /Users/davidann/workspace/ripple/tmp/app/models/general_model.rb to not contain "include Ripple::Document" but it did
     Shared Example Group: "subclass_model_generator" called from /Users/davidann/workspace/ripple/spec/generators/ripple/model_generator_spec.rb:51
     # /Users/davidann/workspace/ripple/spec/generators/ripple/model_generator_spec.rb:16:in `block (2 levels) in <top (required)>'

Finished in 1.4 seconds
639 examples, 2 failures

Failed examples:

rspec /Users/davidann/workspace/ripple/spec/generators/ripple/model_generator_spec.rb:17 # Ripple::Generators::ModelGenerator generating a model with a parent class behaves like subclass_model_generator 
rspec /Users/davidann/workspace/ripple/spec/generators/ripple/model_generator_spec.rb:16 # Ripple::Generators::ModelGenerator generating a model with a parent class behaves like subclass_model_generator 

I'm currently working on solving these issues (I know that dependencies on activesupport are causing this due to changes in how Ruby 2+ deals with respond_to?), but I wanted to raise a flag in case anyone else on the interwebs runs into issues.

This may also be caused by this bug in ruby 2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant