New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Patch set is too large to download', git cl patch gives 404 #527

Open

cdotstout opened this issue Aug 5, 2015 · 1 comment

cdotstout commented Aug 5, 2015

CL has about 320 files. Is this really considered too large?
https://codereview.chromium.org/1259423003/

git cl patch 1259423003:
https://paste.googleplex.com/6558001435508736

Contributor

andialbrecht commented Aug 6, 2015

Rietveld limits responses to 1MB, IIRC. It's likely that a cl with 320 files exceeds this limit.

This limit was necessary in the early ages of Appengine. I'm not sure if this quota limit is still relevant. However, we've never changed it.

IMO such large cl are not reviewable so I have not much interest in changing this limit - but that's just my very own opinion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment