Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge NewModels Branch #32

Open
zhuenink opened this issue Jul 6, 2014 · 3 comments
Open

Merge NewModels Branch #32

zhuenink opened this issue Jul 6, 2014 · 3 comments

Comments

@zhuenink
Copy link
Collaborator

zhuenink commented Jul 6, 2014

I went through and fixed some syntax and compile errors. Should be ready to merge into master. After someone looks through it.
@rlguarino
Copy link
Owner

Shit.

@rlguarino rlguarino reopened this Jul 6, 2014
@rlguarino
Copy link
Owner

From what I just looked at it lookes okay. Have either of you done the merge locally and tested it out? We dont have any unit tests.

@zhuenink
Copy link
Collaborator Author

zhuenink commented Jul 6, 2014

Most of what I fixed were compile issues, haven't tried a local merge yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhuenink @rlguarino