Skip to content
This repository has been archived by the owner on Jan 7, 2019. It is now read-only.

System_Design: All names should be small #21

Open
georgi-g opened this issue Feb 15, 2015 · 1 comment
Open

System_Design: All names should be small #21

georgi-g opened this issue Feb 15, 2015 · 1 comment

Comments

@georgi-g
Copy link
Member

In our xml files name parts must be separated by spaces. During generating code the casing is ignored, but it is partially restricted in xml. see check_name in utils.py

For avoiding confusion and enforce cleaness the names used in xml should be even more restricted.

My suggestion: all names should be written in small, where name parts are separated by spaces.

Small bug in current implementation: names must not start with digits, which passes through the current regular expression.

Hint: The check removed in enum elements in da3f72a does not allow numbers e.g. "line 1", but this should be allowed.

@salkinium
Copy link
Member

I support this. Now also officially.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
xpcc
Backlog
Development

No branches or pull requests

2 participants