Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deny of Service caused by dividing zero without sanity check in jfif.c #13

Closed
sleicasper opened this issue Dec 17, 2019 · 3 comments
Closed

Deny of Service caused by dividing zero without sanity check in jfif.c #13

sleicasper opened this issue Dec 17, 2019 · 3 comments

Comments

@sleicasper
Copy link

file: jfif.c function: jfif_decode line: 425

mcuw = sfh_max * 8;
mcuh = sfv_max * 8;
jw = ALIGN(jfif->width , mcuw);
jh = ALIGN(jfif->height, mcuh);
mcuc = jw / mcuw;                              <------- mcuw can be zero
mcur = jh / mcuh;
//-- calculate mcu info
@sleicasper
Copy link
Author

poc.zip

rockcarry added a commit that referenced this issue Feb 24, 2020
@rockcarry
fix issue #13, by dividing zero without sanity check in jfif.c
d615881
@rockcarry
Copy link
Owner

a new commit push for this issue, please check and test again.

@rockcarry
Copy link
Owner

I test with latest code, issue can not be reproduced.
close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rockcarry @sleicasper