Raise error when trying to set missing attribute #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawburt
commented
Jul 5, 2019
| @@ -647,7 +660,7 @@ | |||
| end | |||
|
|
|||
| it 'allows overrides' do | |||
| user = factories[:user, name: "Joe"] | |||
| user = factories[:user, first_name: "Joe"] | |||
There was a problem hiding this comment.
This is the exact kind of typo I would like to see an error for. I updated name to be first_name but we can just as easily make this be user = factories[:user]. I was not sure what the intent was for updating the name attribute considering there is no specific test that checks the update.
rawburt
commented
Jul 5, 2019
| @@ -7,5 +7,11 @@ def initialize(name) | |||
| super("Factory +#{name}+ not defined") | |||
| end | |||
| end | |||
|
|
|||
| class UnknownFactoryAttributes < StandardError | |||
There was a problem hiding this comment.
I felt like ROM::Factory::UnknownFactoryAttributes was a bit nicer for the user to see than Rom::Factory::Builder::Persistable::UnknownFactoryAttributes
solnic
added a commit
that referenced
this pull request
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always typo some attribute name when using a factory.
rom-factoryignores these typos. This PR makesrom-factoryraise an error instead of the currently "ignore all the things" functionality.I am not sure if this is the best way to solve this problem but "it works" 🤷♂