Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core dependencies not mentioned on dependencies page #379

Open
eguiraud opened this issue Aug 6, 2020 · 7 comments
Open

Core dependencies not mentioned on dependencies page #379

eguiraud opened this issue Aug 6, 2020 · 7 comments
Assignees

Comments

@eguiraud
Copy link
Member

eguiraud commented Aug 6, 2020

The problem: as a user I visited https://root.cern/install/dependencies, I have installed required as well as optional dependencies, and yet configuring a build with cmake -Dfail-on-missing=ON ../root_src does not work, because I'm missing dependencies (or I have to manually turn on their built-in versions.

The minimal working configuration I found was

cmake -Dbuiltin_zstd=ON -Dbuiltin_xxhash=ON -Dfail-on-missing=ON -Dbuiltin_lz4=ON -Dbuiltin_afterimage=ON -Dbuiltin_gl2ps=ON -Doracle=OFF -Dpythia6=OFF -Dpythia8=OFF -Dxrootd=OFF -Dgfal=OFF -Dbuiltin_tbb=ON -Dbuiltin_vdt=ON ../root_src

and note that if I set any of those builtins to OFF, configuration fails.

I think core dependencies that are required for ROOT to work, lest it cannot build, should be listed as dependencies in https://root.cern/install/dependencies.

From Oksana:

in theory there should be libz liblzma liblz4 (it get xxhash as a dependency) and libzstd

I don't know where gl2ps or vdt lie.

@Axel-Naumann
Copy link
Member

But IIUC and IMO these builtins are optional dependencies, as ROOT can build without them being installed, by taking its own.

@eguiraud
Copy link
Member Author

@Axel-Naumann don't you agree that, after installing all dependencies listed at https://root.cern/install/dependencies, the following should work?

cmake -Dfail-on-missing=ON ../root_src

@eguiraud eguiraud removed their assignment Mar 3, 2021
@couet
Copy link
Member

couet commented Mar 16, 2021

@oshadura : I assigned it to you. Feel free to assign it to somebody else if you think that's not your domain.

@oshadura oshadura assigned bellenot and unassigned oshadura Jul 14, 2021
@bellenot
Copy link
Member

@eguiraud before I start to look at this, is it still relevant?

@Axel-Naumann
Copy link
Member

Yes, the page does not list all required dependencies.

@Axel-Naumann
Copy link
Member

@eguiraud

don't you agree that, after installing all dependencies listed at https://root.cern/install/dependencies, the following should work? cmake -Dfail-on-missing=ON ../root_src

Yes, after installing all required dependencies this command must work.

@bellenot
Copy link
Member

OK, I'll check on all platforms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants