Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as_data_frame() was deprecated in tibble 2.0.0.Y #58

Open
rkoenker opened this issue Aug 14, 2023 · 8 comments
Open

as_data_frame() was deprecated in tibble 2.0.0.Y #58

rkoenker opened this issue Aug 14, 2023 · 8 comments

Comments

@rkoenker
Copy link

You probably have already seen this, but if not: I'm getting:
Warning messages:
1: as_data_frame() was deprecated in tibble 2.0.0.
ℹ Please use as_tibble() (with slightly different semantics) to convert to a tibble, or
as.data.frame() to convert to a data frame.
ℹ The deprecated feature was likely used in the bib2df package.
Please report the issue to the authors.
This warning is displayed once every 8 hours.
Call lifecycle::last_lifecycle_warnings() to see where this warning was generated.
2: In bib2df_tidy(bib, separate_names) : NAs introduced by coercion

@giabaio
Copy link
Contributor

giabaio commented Aug 14, 2023

Can you produce a more structure example for where you've seen this problem?

@rkoenker
Copy link
Author

I thought that the warning was fairly clear: Somewhere in bib2df_tidy you need to change as_data_frame to as.data.frame.

@giabaio
Copy link
Contributor

giabaio commented Aug 14, 2023

bib2df_tidydoesn't callas_data_frame` at all... I will look into this later, though.

@giabaio
Copy link
Contributor

giabaio commented Aug 15, 2023

I actually couldn't reproduce this. Using

other attached packages:
[1] bib2df_1.1.2.0

the test based on

bib2df(system.file("extdata", "bib2df_testfile_3.bib", package = "bib2df"))

doesn't produce any error/warning. What was the actual code you were using when you get the warning?

@rkoenker
Copy link
Author

I get the same warning I reported earlier with your test, I'm running bib2df_1.1.1 though, which is the version on CRAN

@giabaio
Copy link
Contributor

giabaio commented Aug 15, 2023

Can you please try to update to the newest version

remotes::install_github("ropensci/bib2df")

and see if this persists? (It shouldn't...)

@rkoenker
Copy link
Author

Yes, that is fine with the new version, but you can't expect users to know about versions on GitHub. You should submit a new version to CRAN.

@SimonGreenhill
Copy link

yes, it was fixed 3 years ago -- can we get a new release on CRAN please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants