Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes induced when using data from Natural Earth 4.1 #69

Closed
2 tasks done
PMassicotte opened this issue Jan 16, 2023 · 4 comments
Closed
2 tasks done

Comments

@PMassicotte
Copy link
Contributor

PMassicotte commented Jan 16, 2023

This is breaking reverse dependencies (when switched to Natural Earth v4.1, https://www.naturalearthdata.com/blog/miscellaneous/natural-earth-v4-1-0-release-notes/)

Before switching to Natural Earth 4.1:

# https://github.com/ropensci/rnaturalearth/commit/3063a52bd76dada68e0873d49f0b79babfbd01dc

pak::pkg_install("ropensci/rnaturalearth@3063a52bd76dada68e0873d49f0b79babfbd01dc", ask = FALSE)

rnaturalearth::ne_countries(scale = "small", returnclass = "sf")[1]

r$> rnaturalearth::ne_countries(scale = "small", returnclass = "sf")[1]
Simple feature collection with 177 features and 1 field
Geometry type: MULTIPOLYGON
Dimension:     XY
Bounding box:  xmin: -180 ymin: -90 xmax: 180 ymax: 83.64513
CRS:           +proj=longlat +datum=WGS84 +no_defs +ellps=WGS84 +towgs84=0,0,0
First 10 features:
  scalerank                       geometry
0         1 MULTIPOLYGON (((61.21082 35...
1         1 MULTIPOLYGON (((16.32653 -5...
2         1 MULTIPOLYGON (((20.59025 41...
3         1 MULTIPOLYGON (((51.57952 24...
4         1 MULTIPOLYGON (((-65.5 -55.2...
5         1 MULTIPOLYGON (((43.58275 41...
6         1 MULTIPOLYGON (((-59.57209 -...
7         3 MULTIPOLYGON (((68.935 -48....
8         1 MULTIPOLYGON (((145.398 -40...
9         1 MULTIPOLYGON (((16.97967 48...

After switching to Natural Earth 4.1:

# https://github.com/ropensci/rnaturalearth/commit/bfeb7ceb6e6539c152b2114dfae4b96d9accc3c3

pak::pkg_install("ropensci/rnaturalearth@bfeb7ceb6e6539c152b2114dfae4b96d9accc3c3", ask = FALSE)

rnaturalearth::ne_countries(scale = "small", returnclass = "sf")[1]

r$> rnaturalearth::ne_countries(scale = "small", returnclass = "sf")[1]
Simple feature collection with 177 features and 1 field
Geometry type: MULTIPOLYGON
Dimension:     XY
Bounding box:  xmin: -180 ymin: -90 xmax: 180 ymax: 83.64513
CRS:           +proj=longlat +datum=WGS84 +no_defs +ellps=WGS84 +towgs84=0,0,0
First 10 features:
       featurecla                       geometry
0 Admin-0 country MULTIPOLYGON (((180 -16.067...
1 Admin-0 country MULTIPOLYGON (((33.90371 -0...
2 Admin-0 country MULTIPOLYGON (((-8.66559 27...
3 Admin-0 country MULTIPOLYGON (((-122.84 49,...
4 Admin-0 country MULTIPOLYGON (((-122.84 49,...
5 Admin-0 country MULTIPOLYGON (((87.35997 49...
6 Admin-0 country MULTIPOLYGON (((55.96819 41...
7 Admin-0 country MULTIPOLYGON (((141.0002 -2...
8 Admin-0 country MULTIPOLYGON (((141.0002 -2...
9 Admin-0 country MULTIPOLYGON (((-68.63401 -...

This change in data structure breaks some reverse dependencies packages:

https://win-builder.r-project.org/incoming_pretest/rnaturalearth_0.3.2_20230116_105021/reverseDependencies/summary.txt

The two packages fail at building their vignettes because the structure of Natural Earth has changed.

@hannahlowens
Copy link

Thanks for the heads-up. I have addressed problem in voluModel, and an update is on its way to CRAN.

@PMassicotte
Copy link
Contributor Author

Thank you very much @hannahlowens!

@PMassicotte
Copy link
Contributor Author

Hi @HannaMeyer, have you had a chance to look at this?

HannaMeyer added a commit to HannaMeyer/CAST that referenced this issue Jan 22, 2023
@HannaMeyer
Copy link

Thanks! It should be fixed in the developer version on Github now. CRAN submission is intended for the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants