New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use vs pbdzmq #29
Comments
I don't use That said, I think it's bad practice to bundle hacked source code for external libraries with R packages when a suitable version of the library is provided by the operating system. The |
awesome - I had a feeling as much. Thanks! btw - any chance you'd ever consider wrapping up a http://www.grpc.io/ implementation? That would be an amazing complement for times when you want a more structured communication approach. |
I think a great question is why that group didn't reach out initially on an integrated package. @snoweye has sent a few patches recently for rzmq to depend on pbdZMQ, and I appreciate the effort, but I don't think that's a good design. @jeroenooms preempted my response, and I agree. Packaging the zmq source with the package is just bad practice. I'm happy the IRKernel team found something they could use on windows (I don't even have a windows dev box), but I think it's unnecessarily complicated. commit a0d6d17
vs commit afd16ca5c6777c4abf3b038848769ca23ab77367
|
seems like they are going for the kitchen-sink approach vs this tightly-scoped implementation |
@dpastoor or anyone else... if you want to collaborate on a grpc wrapper let me know. Will have to monitor the health of the zmq project as sadly Pieter passed away last year. |
@armstrtw I'd love to - that being said, my language repertoire consists of R, javascript, go, and python.... the distinct lack of c++ makes it tough for me to directly contribute to the bindings - however I would be all over documentation, testing, and demonstrating inter-language examples |
|
@jeroenooms its cool to see some new life breathed into this package! Out of curiosity, what was the choice on reviving this vs using/contributing to https://github.com/snoweye/pbdZMQ
nothing against this package at all, just given the IRKernel and other folks have switched to pbdZMQ it would seem to make sense to focus efforts in one place?
The text was updated successfully, but these errors were encountered: