Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed joints parse limits but not axis #193

Open
AdamPettinger opened this issue Jan 10, 2024 · 0 comments
Open

Fixed joints parse limits but not axis #193

AdamPettinger opened this issue Jan 10, 2024 · 0 comments

Comments

@AdamPettinger
Copy link

I have the socket of a ball joint modeled as a fixed link (as a parent to a floating joint for the ball joint). The joint that models where the socket is located is a fixed type joint. I thought it would be nice to pass all relevant location/limit/axis parameters of the socket into my URDF. However, I noticed that the axis tag is not read for fixed (and floating) joints, see below

// Get Joint Axis
if (joint.type != Joint::FLOATING && joint.type != Joint::FIXED)

This is consistent with the standard "Fixed and floating joints do not use the axis field." from here. Why not parse the axis anyway? And relatedly, why parse the axis limits (what is an effort limit for a fixed joint?) but NOT the axis?

Making the change to parse the axis should be easy, and I would be wiling to do it. Am I missing a compelling reason to not parse axes on fixed and floating joints?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant