Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content_available stops sending push notification to Apple APNS silently. #647

Open
sadjow opened this issue Oct 26, 2022 · 3 comments
Open

Comments

@sadjow
Copy link

sadjow commented Oct 26, 2022

Describe the bug
When setting content_available in a rpush's Rpush::Apns2::Notification object. The notification is sent, but it is not displayed on the device.

To Reproduce
Steps to reproduce the behavior:

  1. Create a notification object
n = Rpush::Apns2::Notification.new
n.app = my_valid_app
n.device_token = "valid token here."
n.content_available = true
n.alert = "hi!"
n.data = {
  headers: { 'apns-topic': "valid.topic.here" },
}
n.save!
  1. Run 'Rpush.push`
  2. The notification is delivered, but no warning is displayed, and also it is not displayed.

Expected behavior
We need to warn that the notification should not work because the content available option is not valid anymore on APNS.

Logs and other output
N/A

System configuration (please complete the following information):

  • Rpush version: 7.0.1

Additional context
N/A

@thejspr
Copy link

thejspr commented Jan 31, 2023

I think this is related to this change #596

We just got bit by it as well when upgrading.

@sadjow
Copy link
Author

sadjow commented Jan 31, 2023

@thejspr yes, it was related to the content_available I had to remove it to work. I'm closing this issue.

@sadjow sadjow closed this as completed Jan 31, 2023
@benlangfeld
Copy link
Collaborator

I'm going to leave this open as a marker for the bug introduced in #596 so that others can easily find it.

@benlangfeld benlangfeld reopened this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants