Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config.include/extend no longer respect :type option #159

Closed
jfirebaugh opened this issue Aug 10, 2010 · 2 comments
Closed

config.include/extend no longer respect :type option #159

jfirebaugh opened this issue Aug 10, 2010 · 2 comments

Comments

@jfirebaugh
Copy link
Contributor

As reported here:

http://groups.google.com/group/rspec/browse_thread/thread/fdeca10a5719f19c

The various types of example groups should automatically have an appropriate :type metadatum applied to them, so that this continues to work.
@dchelimsky
Copy link
Contributor

The :type option is added, but it seems that there is an evaluation order problem - the include/extend hooks are sometimes eval'd before the :type property is set. Looking into why.

@dchelimsky
Copy link
Contributor

Fix is in rspec-core: http://github.com/rspec/rspec-core/commit/91cb8a6f7b54ee8a823192a06c668b03ddf6fdda

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dchelimsky @jfirebaugh