/
PassParameterByReferenceQuickFixTests.cs
201 lines (181 loc) · 5.49 KB
/
PassParameterByReferenceQuickFixTests.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
using Microsoft.VisualStudio.TestTools.UnitTesting;
using Moq;
using Rubberduck.Inspections;
using Rubberduck.Inspections.QuickFixes;
using Rubberduck.Inspections.Resources;
using Rubberduck.Parsing.VBA;
using Rubberduck.VBEditor.SafeComWrappers.Abstract;
using RubberduckTests.Mocks;
using System.Collections.Generic;
using System.Linq;
using System.Threading;
namespace RubberduckTests.Inspections
{
[TestClass]
public class AssignedByValParameterChangeToByRefQuickFixTests
{
[TestMethod]
[TestCategory("Inspections")]
public void AssignedByValParameter_PassByReferenceQuickFixWorks()
{
string inputCode =
@"Public Sub Foo(Optional ByVal barByVal As String = ""XYZ"")
Let barByVal = ""test""
End Sub";
string expectedCode =
@"Public Sub Foo(Optional ByRef barByVal As String = ""XYZ"")
Let barByVal = ""test""
End Sub";
var quickFixResult = ApplyPassParameterByReferenceQuickFixToVBAFragment(inputCode);
Assert.AreEqual(expectedCode, quickFixResult);
//check when ByVal argument is one of several parameters
inputCode =
@"Public Sub Foo(ByRef firstArg As Long, Optional ByVal barByVal As String = """", secondArg as Double)
Let barByVal = ""test""
End Sub";
expectedCode =
@"Public Sub Foo(ByRef firstArg As Long, Optional ByRef barByVal As String = """", secondArg as Double)
Let barByVal = ""test""
End Sub";
quickFixResult = ApplyPassParameterByReferenceQuickFixToVBAFragment(inputCode);
Assert.AreEqual(expectedCode, quickFixResult);
//AppleWatch IDE test
inputCode =
@"
Private Sub Foo(Optional ByVal _
bar _
As _
Long = 4, _
ByVal _
barTwo _
As _
Long)
bar = 42
End Sub
"
;
expectedCode =
@"
Private Sub Foo(Optional ByRef _
bar _
As _
Long = 4, _
ByVal _
barTwo _
As _
Long)
bar = 42
End Sub
"
;
quickFixResult = ApplyPassParameterByReferenceQuickFixToVBAFragment(inputCode);
Assert.AreEqual(expectedCode, quickFixResult);
inputCode =
@"Private Sub Foo(ByVal barByVal As Long, ByVal _xByValbar As Long, ByVal _
barTwo _
As _
Long)
barTwo = 42
End Sub
";
expectedCode =
@"Private Sub Foo(ByVal barByVal As Long, ByVal _xByValbar As Long, ByRef _
barTwo _
As _
Long)
barTwo = 42
End Sub
";
quickFixResult = ApplyPassParameterByReferenceQuickFixToVBAFragment(inputCode);
Assert.AreEqual(expectedCode, quickFixResult);
inputCode =
@"Private Sub Foo(ByVal barByVal As Long, ByVal barTwoon As Long, ByVal _
barTwo _
As _
Long)
barTwo = 42
End Sub
";
expectedCode =
@"Private Sub Foo(ByVal barByVal As Long, ByVal barTwoon As Long, ByRef _
barTwo _
As _
Long)
barTwo = 42
End Sub
";
quickFixResult = ApplyPassParameterByReferenceQuickFixToVBAFragment(inputCode);
Assert.AreEqual(expectedCode, quickFixResult);
inputCode =
@"Private Sub Foo(ByVal barByVal As Long, ByVal barTwoon As Long, ByVal barTwo _
As _
Long)
barTwo = 42
End Sub
";
expectedCode =
@"Private Sub Foo(ByVal barByVal As Long, ByVal barTwoon As Long, ByRef barTwo _
As _
Long)
barTwo = 42
End Sub
";
quickFixResult = ApplyPassParameterByReferenceQuickFixToVBAFragment(inputCode);
Assert.AreEqual(expectedCode, quickFixResult);
//weaponized code test
inputCode =
@"Sub DoSomething(_
ByVal foo As Long, _
ByRef _
bar, _
ByRef barbecue _
)
foo = 4
bar = barbecue * _
bar + foo / barbecue
End Sub
";
expectedCode =
@"Sub DoSomething(_
ByRef foo As Long, _
ByRef _
bar, _
ByRef barbecue _
)
foo = 4
bar = barbecue * _
bar + foo / barbecue
End Sub
";
quickFixResult = ApplyPassParameterByReferenceQuickFixToVBAFragment(inputCode);
Assert.AreEqual(expectedCode, quickFixResult);
}
private string ApplyPassParameterByReferenceQuickFixToVBAFragment(string inputCode)
{
var vbe = BuildMockVBEStandardModuleForVBAFragment(inputCode);
var inspectionResults = GetAssignedByValParameterInspectionResults(vbe.Object);
inspectionResults.First().QuickFixes.Single(s => s is PassParameterByReferenceQuickFix).Fix();
return GetModuleContent(vbe.Object);
}
private string GetModuleContent(IVBE vbe)
{
var project = vbe.VBProjects[0];
var module = project.VBComponents[0].CodeModule;
return module.Content();
}
private IEnumerable<Rubberduck.Inspections.Abstract.InspectionResultBase> GetAssignedByValParameterInspectionResults(IVBE vbe)
{
var parser = MockParser.Create(vbe, new RubberduckParserState(vbe));
parser.Parse(new CancellationTokenSource());
if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var inspection = new AssignedByValParameterInspection(parser.State,null);
return inspection.GetInspectionResults();
}
private Mock<IVBE> BuildMockVBEStandardModuleForVBAFragment(string inputCode)
{
var builder = new MockVbeBuilder();
IVBComponent component;
return builder.BuildFromSingleStandardModule(inputCode, out component);
}
}
}