/
MemberNotOnInterfaceInspectionTests.cs
329 lines (272 loc) · 10.3 KB
/
MemberNotOnInterfaceInspectionTests.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
using System.Linq;
using System.Threading;
using NUnit.Framework;
using Rubberduck.Inspections.Concrete;
using Rubberduck.Parsing.VBA;
using Rubberduck.VBEditor.SafeComWrappers;
using RubberduckTests.Mocks;
using ParserState = Rubberduck.Parsing.VBA.ParserState;
namespace RubberduckTests.Inspections
{
[TestFixture]
public class MemberNotOnInterfaceInspectionTests
{
private static RubberduckParserState ArrangeParserAndParse(string inputCode, string library = "Scripting")
{
var builder = new MockVbeBuilder();
var project = builder.ProjectBuilder("VBAProject", ProjectProtection.Unprotected)
.AddComponent("Codez", ComponentType.StandardModule, inputCode)
.AddReference(library,
library.Equals("Scripting") ? MockVbeBuilder.LibraryPathScripting : MockVbeBuilder.LibraryPathMsExcel,
1,
library.Equals("Scripting") ? 0 : 8,
true)
.Build();
var vbe = builder.AddProject(project).Build();
var parser = MockParser.Create(vbe.Object);
parser.State.AddTestLibrary(library.Equals("Scripting") ? "Scripting.1.0.xml" : "Excel.1.8.xml");
parser.Parse(new CancellationTokenSource());
if (parser.State.Status >= ParserState.Error)
{
Assert.Inconclusive("Parser Error");
}
return parser.State;
}
[Test]
[Category("Inspections")]
public void MemberNotOnInterface_ReturnsResult_UnDeclaredMember()
{
const string inputCode =
@"Sub Foo()
Dim dict As Dictionary
Set dict = New Dictionary
dict.NonMember
End Sub";
using (var state = ArrangeParserAndParse(inputCode))
{
var inspection = new MemberNotOnInterfaceInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.AreEqual(1, inspectionResults.Count());
}
}
[Test]
[Category("Inspections")]
public void MemberNotOnInterface_ReturnsResult_UnDeclaredInterfaceMember()
{
const string inputCode =
@"Sub Foo()
Dim dict As Dictionary
Set dict = New Dictionary
dict.NonMember
End Sub";
using (var state = ArrangeParserAndParse(inputCode))
{
var inspection = new MemberNotOnInterfaceInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.AreEqual(1, inspectionResults.Count());
}
}
[Test]
[Category("Inspections")]
public void MemberNotOnInterface_ReturnsResult_ApplicationObject()
{
const string inputCode =
@"Sub Foo()
Application.NonMember
End Sub";
using (var state = ArrangeParserAndParse(inputCode, "Excel"))
{
var inspection = new MemberNotOnInterfaceInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.AreEqual(1, inspectionResults.Count());
}
}
[Test]
[Category("Inspections")]
public void MemberNotOnInterface_ReturnsResult_UnDeclaredMemberOnParameter()
{
const string inputCode =
@"Sub Foo(dict As Dictionary)
dict.NonMember
End Sub";
using (var state = ArrangeParserAndParse(inputCode))
{
var inspection = new MemberNotOnInterfaceInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.AreEqual(1, inspectionResults.Count());
}
}
[Test]
[Category("Inspections")]
public void MemberNotOnInterface_DoesNotReturnResult_DeclaredMember()
{
const string inputCode =
@"Sub Foo()
Dim dict As Dictionary
Set dict = New Dictionary
Debug.Print dict.Count
End Sub";
using (var state = ArrangeParserAndParse(inputCode))
{
var inspection = new MemberNotOnInterfaceInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.IsFalse(inspectionResults.Any());
}
}
[Test]
[Category("Inspections")]
public void MemberNotOnInterface_DoesNotReturnResult_NonExtensible()
{
const string inputCode =
@"Sub Foo()
Dim x As File
Debug.Print x.NonMember
End Sub";
using (var state = ArrangeParserAndParse(inputCode))
{
var inspection = new MemberNotOnInterfaceInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.IsFalse(inspectionResults.Any());
}
}
[Test]
[Category("Inspections")]
public void MemberNotOnInterface_ReturnsResult_WithBlock()
{
const string inputCode =
@"Sub Foo()
Dim dict As New Dictionary
With dict
.NonMember
End With
End Sub";
using (var state = ArrangeParserAndParse(inputCode))
{
var inspection = new MemberNotOnInterfaceInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.AreEqual(1, inspectionResults.Count());
}
}
[Test]
[Category("Inspections")]
public void MemberNotOnInterface_DoesNotReturnResult_BangNotation()
{
const string inputCode =
@"Sub Foo()
Dim dict As Dictionary
Set dict = New Dictionary
dict!SomeIdentifier = 42
End Sub";
using (var state = ArrangeParserAndParse(inputCode))
{
var inspection = new MemberNotOnInterfaceInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.IsFalse(inspectionResults.Any());
}
}
[Test]
[Category("Inspections")]
public void MemberNotOnInterface_DoesNotReturnResult_WithBlockBangNotation()
{
const string inputCode =
@"Sub Foo()
Dim dict As New Dictionary
With dict
!SomeIdentifier = 42
End With
End Sub";
using (var state = ArrangeParserAndParse(inputCode))
{
var inspection = new MemberNotOnInterfaceInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.IsFalse(inspectionResults.Any());
}
}
[Test]
[Category("Inspections")]
public void MemberNotOnInterface_DoesNotReturnResult_ProjectReference()
{
const string inputCode =
@"Sub Foo()
Dim dict As Scripting.Dictionary
End Sub";
using (var state = ArrangeParserAndParse(inputCode))
{
var inspection = new MemberNotOnInterfaceInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.IsFalse(inspectionResults.Any());
}
}
[Test]
[Category("Inspections")]
public void MemberNotOnInterface_Ignored_DoesNotReturnResult()
{
const string inputCode =
@"Sub Foo(dict As Dictionary)
Dim dict As Dictionary
Set dict = New Dictionary
'@Ignore MemberNotOnInterface
dict.NonMember
End Sub";
using (var state = ArrangeParserAndParse(inputCode))
{
var inspection = new MemberNotOnInterfaceInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.IsFalse(inspectionResults.Any());
}
}
[Test]
[Category("Inspections")]
public void MemberNotOnInterface_CatchesInvalidUseOfMember()
{
const string userForm1Code = @"
Private _fooBar As String
Public Property Let FooBar(value As String)
_fooBar = value
End Property
Public Property Get FooBar() As String
FooBar = _fooBar
End Property
";
const string analyzedCode = @"Option Explicit
Sub FizzBuzz()
Dim bar As UserForm1
Set bar = New UserForm1
bar.FooBar = ""FooBar""
Dim foo As UserForm
Set foo = New UserForm1
foo.FooBar = ""BarFoo""
End Sub
";
var mockVbe = new MockVbeBuilder();
var projectBuilder = mockVbe.ProjectBuilder("testproject", ProjectProtection.Unprotected);
projectBuilder.MockUserFormBuilder("UserForm1", userForm1Code).AddFormToProjectBuilder()
.AddComponent("ReferencingModule", ComponentType.StandardModule, analyzedCode)
//.AddReference("Excel", MockVbeBuilder.LibraryPathMsExcel)
.AddReference("MSForms", MockVbeBuilder.LibraryPathMsForms, 2, 0);
mockVbe.AddProject(projectBuilder.Build());
var parser = MockParser.Create(mockVbe.Build().Object);
//parser.State.AddTestLibrary("Excel.1.8.xml");
parser.State.AddTestLibrary("MSForms.2.0.xml");
parser.Parse(new CancellationTokenSource());
if (parser.State.Status >= ParserState.Error)
{
Assert.Inconclusive("Parser Error");
}
using (var state = parser.State)
{
var inspection = new MemberNotOnInterfaceInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.IsTrue(inspectionResults.Any());
}
}
[Test]
[Category("Inspections")]
public void InspectionName()
{
const string inspectionName = "MemberNotOnInterfaceInspection";
var inspection = new MemberNotOnInterfaceInspection(null);
Assert.AreEqual(inspectionName, inspection.Name);
}
}
}