Merge pull request #2318 from retailcoder/next

minor fixes

Author: retailcoder

RetailCoder.VBE/Inspections/ImplicitActiveSheetReferenceInspection.cs

@@ -40,7 +40,7 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
                         item.AsTypeName == "Range").ToList();
 
             var issues = matches.Where(item => item.References.Any())
-                .SelectMany(declaration => declaration.References);
+                .SelectMany(declaration => declaration.References.Distinct());
 
             return issues.Select(issue => 
                 new ImplicitActiveSheetReferenceInspectionResult(this, issue));

RetailCoder.VBE/Inspections/ImplicitActiveWorkbookReferenceInspection.cs

@@ -37,14 +37,14 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
         {
             if (_hostApp == null || _hostApp.ApplicationName != "Excel")
             {
-                return new InspectionResultBase[] { };
+                return Enumerable.Empty<InspectionResultBase>();
                 // if host isn't Excel, the ExcelObjectModel declarations shouldn't be loaded anyway.
             }
 
             var issues = BuiltInDeclarations.Where(item => ParentScopes.Contains(item.ParentScope)
                                             && Targets.Contains(item.IdentifierName)
                                             && item.References.Any())
-                .SelectMany(declaration => declaration.References);
+                .SelectMany(declaration => declaration.References.Distinct());
 
             return issues.Select(issue =>
                 new ImplicitActiveWorkbookReferenceInspectionResult(this, issue));

RetailCoder.VBE/UI/Command/FindAllReferencesCommand.cs

@@ -140,7 +140,7 @@ protected override void ExecuteImpl(object parameter)
 
         private SearchResultsViewModel CreateViewModel(Declaration declaration)
         {
-            var results = declaration.References.Select(reference =>
+            var results = declaration.References.Distinct().Select(reference =>
                 new SearchResultItem(
                     reference.ParentNonScoping,
                     new NavigateCodeEventArgs(reference.QualifiedModuleName, reference.Selection), 

Rubberduck.Parsing/Symbols/IdentifierReference.cs

@@ -5,11 +5,12 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Diagnostics;
+using System;
 
 namespace Rubberduck.Parsing.Symbols
 {
     [DebuggerDisplay("({IdentifierName}) IsAss:{IsAssignment} | {Selection} ")]
-    public class IdentifierReference
+    public class IdentifierReference : IEquatable<IdentifierReference>
     {
         public IdentifierReference(
             QualifiedModuleName qualifiedName, 
@@ -124,5 +125,23 @@ public bool IsSelected(QualifiedSelection selection)
             return QualifiedModuleName == selection.QualifiedName &&
                    Selection.ContainsFirstCharacter(selection.Selection);
         }
+
+        public bool Equals(IdentifierReference other)
+        {
+            return other != null
+                && other.QualifiedModuleName.Equals(QualifiedModuleName)
+                && other.Selection.Equals(Selection)
+                && other.Declaration.Equals(Declaration);
+        }
+
+        public override bool Equals(object obj)
+        {
+            return Equals(obj as IdentifierReference);
+        }
+
+        public override int GetHashCode()
+        {
+            return HashCode.Compute(QualifiedModuleName, Selection, Declaration);
+        }
     }
 }

Rubberduck.Parsing/Symbols/ReferencedDeclarationsCollector.cs

@@ -60,7 +60,7 @@ public ReferencedDeclarationsCollector(RubberduckParserState state)
 
         private static readonly IDictionary<VarEnum, string> TypeNames = new Dictionary<VarEnum, string>
         {
-            {VarEnum.VT_DISPATCH, "DISPATCH"},
+            {VarEnum.VT_DISPATCH, "Object"},
             {VarEnum.VT_VOID, string.Empty},
             {VarEnum.VT_VARIANT, "Variant"},
             {VarEnum.VT_BLOB_OBJECT, "Object"},