Merge pull request #1462 from Vogel612/MinimalChanges

Followup for #1453

Author: retailcoder

Rubberduck.Parsing/VBA/RubberduckParserState.cs

@@ -287,49 +287,11 @@ private set
             }
         }
 
-        private IEnumerable<QualifiedContext> _obsoleteCallContexts = new List<QualifiedContext>();
-
-        /// <summary>
-        /// Gets <see cref="ParserRuleContext"/> objects representing 'Call' statements in the parse tree.
-        /// </summary>
-        public IEnumerable<QualifiedContext> ObsoleteCallContexts
-        {
-            get { return _obsoleteCallContexts; }
-            internal set { _obsoleteCallContexts = value; }
-        }
-
-        private IEnumerable<QualifiedContext> _obsoleteLetContexts = new List<QualifiedContext>();
-
-        /// <summary>
-        /// Gets <see cref="ParserRuleContext"/> objects representing explicit 'Let' statements in the parse tree.
-        /// </summary>
-        public IEnumerable<QualifiedContext> ObsoleteLetContexts
-        {
-            get { return _obsoleteLetContexts; }
-            internal set { _obsoleteLetContexts = value; }
-        }
-
         internal void SetModuleAttributes(VBComponent component, IDictionary<Tuple<string, DeclarationType>, Attributes> attributes)
         {
             _moduleAttributes.AddOrUpdate(new QualifiedModuleName(component), attributes, (c, s) => attributes);
         }
 
-        private IEnumerable<QualifiedContext> _emptyStringLiterals = new List<QualifiedContext>();
-
-        public IEnumerable<QualifiedContext> EmptyStringLiterals
-        {
-            get { return _emptyStringLiterals; }
-            internal set { _emptyStringLiterals = value; }
-        }
-
-        private IEnumerable<QualifiedContext> _argListsWithOneByRefParam = new List<QualifiedContext>();
-
-        public IEnumerable<QualifiedContext> ArgListsWithOneByRefParam
-        {
-            get { return _argListsWithOneByRefParam; }
-            internal set { _argListsWithOneByRefParam = value; }
-        }
-
         public IEnumerable<CommentNode> AllComments
         {
             get

RubberduckTests/Inspections/EmptyStringLiteralInspectionTests.cs

@@ -42,7 +42,7 @@ Public Sub Foo(ByRef arg1 As String)
             parser.Parse();
             if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
 
-            var inspection = new EmptyStringLiteralInspection(parser.State);
+            var inspection = new EmptyStringLiteralInspection(null);
             var inspector = new Inspector(settings.Object, new IInspection[] { inspection });
 
             var inspectionResults = inspector.FindIssuesAsync(parser.State, CancellationToken.None).Result;
@@ -73,7 +73,7 @@ public void EmptyStringLiteral_ReturnsResult_Assignment()
             parser.Parse();
             if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
 
-            var inspection = new EmptyStringLiteralInspection(parser.State);
+            var inspection = new EmptyStringLiteralInspection(null);
             var inspector = new Inspector(settings.Object, new IInspection[] { inspection });
 
             var inspectionResults = inspector.FindIssuesAsync(parser.State, CancellationToken.None).Result;
@@ -104,7 +104,7 @@ public void NotEmptyStringLiteral_DoesNotReturnResult()
             parser.Parse();
             if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
 
-            var inspection = new EmptyStringLiteralInspection(parser.State);
+            var inspection = new EmptyStringLiteralInspection(null);
             var inspector = new Inspector(settings.Object, new IInspection[] { inspection });
 
             var inspectionResults = inspector.FindIssuesAsync(parser.State, CancellationToken.None).Result;
@@ -142,7 +142,7 @@ public void EmptyStringLiteral_QuickFixWorks()
             parser.Parse();
             if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
 
-            var inspection = new EmptyStringLiteralInspection(parser.State);
+            var inspection = new EmptyStringLiteralInspection(null);
             var inspector = new Inspector(settings.Object, new IInspection[] { inspection });
 
             var inspectionResults = inspector.FindIssuesAsync(parser.State, CancellationToken.None).Result;