Merge branch 'next' into next

Author: shadowofsilicon

README.md

@@ -1,5 +1,11 @@
 <img src="http://i.stack.imgur.com/jnBEp.jpg" width=100% />
 
+### Donate!
+
+If you like this project and would like to thank its contributors, you are welcome to support our GoFundMe campaign to finance Rubberduck swag and international shipping - contributors will be getting t-shirts, mugs, and other cool things.
+
+[![GoFundMe campaign](https://user-images.githubusercontent.com/5751684/29191799-e3d20b72-7dec-11e7-8ec6-0c69da4a3135.png)](https://www.gofundme.com/rubberduckvba)
+
 Branch     | Description | Build Status |
 |------------|---|--------------|
 | **master** | The last released build | ![master branch build status][masterBuildStatus] |

RetailCoder.VBE/Properties/AssemblyInfo.cs

@@ -9,7 +9,7 @@
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("Rubberduck")]
 [assembly: AssemblyProduct("Rubberduck")]
-[assembly: AssemblyCopyright("Copyright ©  2014-2016")]
+[assembly: AssemblyCopyright("Copyright ©  2014-2017")]
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 
@@ -31,5 +31,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("2.0.14.*")]
-[assembly: AssemblyFileVersion("2.0.14.0")]
+[assembly: AssemblyVersion("2.1.0.*")]
+[assembly: AssemblyFileVersion("2.1.0.0")]

RetailCoder.VBE/UI/About/AboutControl.xaml

@@ -37,14 +37,20 @@
                     HorizontalAlignment="Left"
                     VerticalAlignment="Top"
                     Margin="5,0,0,5" Height="316" Width="175">
-            <Image Source="{StaticResource Ducky}" Stretch="UniformToFill" Height="292" />
-            <TextBlock HorizontalAlignment="Center" Margin="0,5,0,0">
+            <Image Source="{StaticResource Ducky}" Stretch="UniformToFill" Height="250" />
+            <TextBlock HorizontalAlignment="Center" Margin="0,30,0,0">
                 <Hyperlink Name="WebpageHyperlink"
                            NavigateUri="http://rubberduckvba.com/"
                            FontWeight="Bold"
                            Command="{Binding UriCommand}"
                            CommandParameter="{Binding ElementName=WebpageHyperlink, Path=NavigateUri}">rubberduckvba.com</Hyperlink>
             </TextBlock>
+            <TextBlock HorizontalAlignment="Center" Margin="0">
+                <Hyperlink Name="GoFundMeHyperlink"
+                           NavigateUri="http://gofundme.com/rubberduckvba/"
+                           Command="{Binding UriCommand}"
+                           CommandParameter="{Binding ElementName=GoFundMeHyperlink, Path=NavigateUri}">gofundme.com/rubberduckvba</Hyperlink>
+            </TextBlock>
         </StackPanel>
         <StackPanel Grid.Column="1"
                     Grid.Row="1"
@@ -81,10 +87,13 @@ Stack Overflow
                     <TextBlock FontSize="10"
                                xml:space="preserve">Abraham Hosch
 Andrew Jackson
+Andrew Zschetzsche
 Andrin Meier
+Brandon Barney
+Brian Zenger
 Bruno Costa
-BZngr
 Carlos J. Quintero (MZ-Tools)
+Clemens Lieb
 @Comintern
 @daFreeMan
 @Duga SE chat bot
@@ -93,11 +102,13 @@ Frank Van Heeswijk
 Gareth Leachman
 @Heslacher
 INOPIAE
+@IvenBach
 Jeroen Vannevel
 Max Dörner
 Michal Krzych
 @mjolka
 Philip Wales
+Radosław Kapka
 Rob Bovey (Smart Indenter)
 Ross McLean
 Ross Knudsen
@@ -118,7 +129,7 @@ Stephen Bullen (Smart Indenter)
                 <!-- Circle logos created with Ai->XAML Export Plug-In Version 0.2 (PC/64) -->
                 <!-- By Mike Swanson (http://blog.mikeswanson.com/)           -->
 
-                <StackPanel Margin="2,0,20,0" HorizontalAlignment="Center">
+                <StackPanel Margin="2,5,10,0" HorizontalAlignment="Center">
                     <TextBlock TextAlignment="Center" HorizontalAlignment="Center">
                     <Hyperlink Name="GitHubUrl"
                                NavigateUri="https://github.com/rubberduck-vba/Rubberduck"
@@ -136,9 +147,9 @@ Stephen Bullen (Smart Indenter)
                         </Viewbox>
                     </Hyperlink>
                     </TextBlock>
-                    <TextBlock Text="GitHub" FontSize="9" TextAlignment="Center" />
+                    <!--<TextBlock Text="GitHub" FontSize="9" TextAlignment="Center" />-->
                 </StackPanel>
-                <StackPanel Margin="25,0,0,0" HorizontalAlignment="Center">
+                <StackPanel Margin="25,5,0,0" HorizontalAlignment="Center">
                     <TextBlock TextAlignment="Center" HorizontalAlignment="Center">
                     <Hyperlink Name="TwitterUrl"
                                NavigateUri="http://www.twitter.com/rubberduckvba"
@@ -156,7 +167,7 @@ Stephen Bullen (Smart Indenter)
                         </Viewbox>
                     </Hyperlink>
                     </TextBlock>
-                    <TextBlock Text="Twitter" FontSize="9" TextAlignment="Center" />
+                    <!--<TextBlock Text="Twitter" FontSize="9" TextAlignment="Center" />-->
                 </StackPanel>
             </StackPanel>
         </Border>

Rubberduck.Inspections/Abstract/InspectionBase.cs

@@ -24,6 +24,11 @@ protected InspectionBase(RubberduckParserState state, CodeInspectionSeverity def
             Name = GetType().Name;
         }
 
+        /// <summary>
+        /// Gets the type of the inspection class. GetType() returns an interceptor proxy type.
+        /// </summary>
+        public abstract Type Type { get; }
+
         /// <summary>
         /// Gets a value the severity level to reset to, the "factory default" setting.
         /// </summary>

Rubberduck.Inspections/Concrete/ApplicationWorksheetFunctionInspection.cs

@@ -1,7 +1,9 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.Linq;
 using Rubberduck.Inspections.Abstract;
 using Rubberduck.Inspections.Results;
+using Rubberduck.Parsing.Inspections;
 using Rubberduck.Parsing.Inspections.Abstract;
 using Rubberduck.Parsing.Inspections.Resources;
 using Rubberduck.Parsing.Symbols;
@@ -10,11 +12,14 @@
 
 namespace Rubberduck.Inspections.Concrete
 {
+    [RequiredLibrary("Excel")]
     public class ApplicationWorksheetFunctionInspection : InspectionBase
     {
         public ApplicationWorksheetFunctionInspection(RubberduckParserState state)
             : base(state, CodeInspectionSeverity.Suggestion) { }
 
+        public override Type Type => typeof(ApplicationWorksheetFunctionInspection);
+
         public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
 
         public override IEnumerable<IInspectionResult> GetInspectionResults()

Rubberduck.Inspections/Concrete/AssignedByValParameterInspection.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using Rubberduck.Inspections.Abstract;
@@ -17,6 +18,8 @@ public AssignedByValParameterInspection(RubberduckParserState state)
             Severity = DefaultSeverity;
         }
 
+        public override Type Type => typeof(AssignedByValParameterInspection);
+
         public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
 
         public override IEnumerable<IInspectionResult> GetInspectionResults()

Rubberduck.Inspections/Concrete/ConstantNotUsedInspection.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using Antlr4.Runtime;
@@ -17,6 +18,8 @@ public sealed class ConstantNotUsedInspection : InspectionBase
         public ConstantNotUsedInspection(RubberduckParserState state)
             : base(state) { }
 
+        public override Type Type => typeof(ConstantNotUsedInspection);
+
         public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
 
         public override IEnumerable<IInspectionResult> GetInspectionResults()

Rubberduck.Inspections/Concrete/DefaultProjectNameInspection.cs

@@ -1,19 +1,24 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.Linq;
 using Rubberduck.Inspections.Abstract;
 using Rubberduck.Inspections.Results;
+using Rubberduck.Parsing.Inspections;
 using Rubberduck.Parsing.Inspections.Abstract;
 using Rubberduck.Parsing.Inspections.Resources;
 using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA;
 
 namespace Rubberduck.Inspections.Concrete
 {
+    [CannotAnnotate]
     public sealed class DefaultProjectNameInspection : InspectionBase
     {
         public DefaultProjectNameInspection(RubberduckParserState state)
             : base(state, CodeInspectionSeverity.Suggestion) { }
 
+        public override Type Type => typeof(DefaultProjectNameInspection);
+
         public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
         public override IEnumerable<IInspectionResult> GetInspectionResults()

Rubberduck.Inspections/Concrete/EmptyElseBlockInspection.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.Linq;
 using Antlr4.Runtime;
 using Rubberduck.Parsing.Grammar;
@@ -18,6 +19,8 @@ internal class EmptyElseBlockInspection : ParseTreeInspectionBase
     {
         public EmptyElseBlockInspection(RubberduckParserState state) : base(state, CodeInspectionSeverity.Suggestion) { }
 
+        public override Type Type => typeof(EmptyElseBlockInspection);
+
         public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
 
         public override IInspectionListener Listener { get; } = new EmptyElseBlockListener();
@@ -28,7 +31,6 @@ public override IEnumerable<IInspectionResult> GetInspectionResults()
                 .Where(result => !IsIgnoringInspectionResultFor(result.ModuleName, result.Context.Start.Line))
                 .Select(result => new QualifiedContextInspectionResult(this,
                                                         InspectionsUI.EmptyElseBlockInspectionResultFormat,
-                                                        State,
                                                         result));
         }
 

Rubberduck.Inspections/Concrete/EmptyIfBlockInspection.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
 using Antlr4.Runtime;
@@ -19,6 +20,8 @@ internal class EmptyIfBlockInspection : ParseTreeInspectionBase
         public EmptyIfBlockInspection(RubberduckParserState state)
             : base(state) { }
 
+        public override Type Type => typeof(EmptyIfBlockInspection);
+
         public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
 
         public override IInspectionListener Listener { get; } =
@@ -30,7 +33,6 @@ public override IEnumerable<IInspectionResult> GetInspectionResults()
                 .Where(result => !IsIgnoringInspectionResultFor(result.ModuleName, result.Context.Start.Line))
                 .Select(result => new QualifiedContextInspectionResult(this,
                                                        InspectionsUI.EmptyIfBlockInspectionResultFormat,
-                                                       State,
                                                        result));
         }