Make the parameter for state and OldState non-optional.

Author: bclothier

Rubberduck.Parsing/VBA/RubberduckParserState.cs

@@ -390,7 +390,7 @@ public IReadOnlyList<Tuple<QualifiedModuleName, SyntaxErrorException>> ModuleExc
         public event EventHandler<ParserStateEventArgs> StateChanged;
 
         private int _stateChangedInvocations;
-        private void OnStateChanged(object requestor, CancellationToken token, ParserState state = ParserState.Pending, ParserState oldStatus = ParserState.Pending)
+        private void OnStateChanged(object requestor, CancellationToken token, ParserState state, ParserState oldStatus)
         {
             Interlocked.Increment(ref _stateChangedInvocations);
 
@@ -610,7 +610,7 @@ public void SetStatusAndFireStateChanged(object requestor, ParserState status, C
         {
             if (Status == status)
             {
-                OnStateChanged(requestor, token, status);
+                OnStateChanged(requestor, token, status, _status);
             }
             else
             {

RubberduckTests/Mocks/MockParser.cs

@@ -121,19 +121,6 @@ public static RubberduckParserState CreateAndParse(IVBE vbe, string serializedDe
             return parser.State;
         }
 
-        private static SynchronousParseCoordinator CreateWithLibraries(IVBE vbe, string serializedDeclarationsPath = null, IEnumerable<string> testLibraries = null)
-        {
-            var parser = Create(vbe, serializedDeclarationsPath);
-            if (testLibraries != null)
-            {
-                foreach (var lib in testLibraries)
-                {
-                    parser.State.AddTestLibrary(lib);
-                }
-            }
-            return parser;
-        }
-
         private static readonly HashSet<DeclarationType> ProceduralTypes =
             new HashSet<DeclarationType>(new[]
             {