Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'next' into 5664_ReadOnlyLocalFields
- Loading branch information
Showing
100 changed files
with
2,005 additions
and
958 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,99 +1,78 @@ | ||
| # Contributing to Rubberduck | ||
|  | ||
|
|
||
| Thank you very much for taking the time to contribute! | ||
| Thank you for your interest in contributing to improve Rubberduck! | ||
|
|
||
| The following is a set of guidelines and links to helpful resources to get you started. | ||
| Below should be everything you need to know to get started with contributing to this project. | ||
|
|
||
| ## Code of Conduct | ||
| --- | ||
|
|
||
| Rubberduck as of now has no formalized Code of Conduct. | ||
| Yet the following guidelines apply in no particular order: | ||
| ## GitHub | ||
|
|
||
| - Apply common sense?! | ||
| - Show and deserve respect | ||
| - Be nice | ||
| - We don't bite :) | ||
| - Assume people's best intentions unless proven otherwise | ||
| [Get started with GitHub](https://docs.github.com/en/github/getting-started-with-github) first, star ⭐ us if you haven't already (it helps boosting the project's visibility on the GitHub platform!), and you'll hit the ground running in no time. | ||
|
|
||
| ## How can I contribute? | ||
| ## Non-Code Contributions | ||
|
|
||
| ### Bug Reports | ||
| Don't know any C#? No problem, there is still plenty you can do to help! | ||
|
|
||
| The development team is always happy to hear about bugs. Reported bugs and other issues are opportunities to make Rubberduck even better. | ||
| ### Issues | ||
|
|
||
| Before you report your bug, please check the [GitHub Issues](https://github.com/rubberduck-vba/Rubberduck/issues). | ||
| The team spends quite some time to label the issues nicely so that you can find already known problems. | ||
| This project uses the GitHub issue tracker to document ideas and suggest enhancements, as well as bugs. Because this creates _lots_ of issues, we take the time to carefully label each one, to facilitate searching and browsing. | ||
|
|
||
| To enable the fastest response possible, please include the following information in your Bug report wherever applicable: | ||
| Please review the existing open [](https://github.com/rubberduck-vba/Rubberduck/issues?q=is%3Aissue+is%3Aopen+label%3Abug) issues (search filter `is:issue is:open label:bug`) to avoid duplicating a known issue. | ||
| - 👍 upvote existing issues and ideas you'd wish were fixed or implemented. | ||
| - 💬 share your feedback and ideas, even (especially!) if it's "just a small thing". | ||
| - ✔️ submitting a bug? Please provide _and test_ clear steps to reproduce the problem, upload screenshots and/or include the logged exception stack trace(s), as applicable: the quicker we can track down a bug, the quicker we can fix it! | ||
| - ❌ some excellent ideas are out-of-scope for this project; don't fret a rejected idea for an enhancement that is deemed too large or too complex to maintain. *It's not you, it's us!* | ||
| - ❌ when posting a CLR/JIT stack trace, please avoid cluttering the issue with the "loaded assemblies" part; that (very) long list of loaded DLLs is not relevant. | ||
|
|
||
| - The Version of Rubberduck you are running. | ||
| - Steps to reproduce the issue (Code?). | ||
| - A **full and complete** logfile, preferrably at TRACE-level | ||
| - Screenshots? | ||
| - ... | ||
| ### Wiki | ||
|
|
||
| When posting a CLR/JIT stack trace, please avoid cluttering the issue with the "loaded assemblies" part; that (very) long list of loaded DLL's isn't relevant. | ||
| The [wiki](https://github.com/rubberduck-vba/Rubberduck/wiki) is open for editing, and contributions are welcome. | ||
|
|
||
| ### Suggesting Enhancements | ||
| - ✏️ edit existing content to fix typos, update screenshots. | ||
| - 📄 add new pages to document the source code and internal API. | ||
|
|
||
| The team is always happy to hear your ideas. Please do make sure you checked, whether someone else already requested something similar. | ||
| The label [enhancement] will be a good guide. | ||
| ### XML Documentation | ||
|
|
||
| Do note that despite the rather large scope of Rubberduck, some things are just **too large** or **too complex** for Rubberduck to effectively support. | ||
| Please don't be discouraged if your idea gets declined, your feedback is very valuable. | ||
| The source code contains XML documentation that is compiled as an asset and that is ultimately used to generate content (English only) that is rendered on the website and sometimes accessible as an online resource from within Rubberduck. | ||
|
|
||
| As with Bug Reports the more exact you define what's your gripe, the quicker we can get back to you. | ||
| Each page on the website generated from XML documentation in the source code, includes a link to 'edit this page' that points to the corresponding C# source file. With a GitHub login, it is easy to contribute enhancements to the documentation and content presented on the project's website. | ||
|
|
||
| ### The Wiki | ||
| You will find the XML documentation in the following folders/namespaces: | ||
|
|
||
| The Rubberduck Wiki is open for editing to everybody that has a Github account. | ||
| This is very much intentional. | ||
| Everybody is welcome to improve and expand the wiki. | ||
| - [Rubberduck.CodeAnalysis.Inspections.Concrete](https://github.com/rubberduck-vba/Rubberduck/blob/next/Rubberduck.CodeAnalysis/Inspections/Concrete/README.md) | ||
| - [Rubberduck.CodeAnalysis.QuickFixes.Concrete](https://github.com/rubberduck-vba/Rubberduck/blob/next/Rubberduck.CodeAnalysis/QuickFixes/Concrete/README.md) | ||
| - [Rubberduck.Parsing.Annotations.Concrete](https://github.com/rubberduck-vba/Rubberduck/tree/next/Rubberduck.Parsing/Annotations/Concrete) | ||
|
|
||
| ### Coding and Related | ||
| ### Just Saying Thanks | ||
|
|
||
| So you want to get your hands dirty and fix that obnoxious bug in the last release? | ||
| Well **great**, we like seeing new faces in the fray :) | ||
| Or you just want to find something that you can contribute to to learn C#? Or ... | ||
| Well whatever your motivation is, we recommend taking a look at issues that are labeled [\[up-for-grabs\]](https://github.com/rubberduck-vba/Rubberduck/issues?q=is%3Aissue+is%3Aopen+label%3Aup-for-grabs). | ||
| Maintaining open-source software is often a thankless, selfless activity that involves a small and volunteering contributor force. If you ❤️ what we're doing here, we want to hear from you! Sure every ⭐ star gives us a warm fuzzy feeling of making a bit of a difference somewhere, but reading how our work impacts yours beats everything else. | ||
|
|
||
| Our Ducky has come quite the long way and is intimidatingly large for a first-time (or even long-time) contributor. | ||
| To make it easier to find something you can do, all issues with that label are additionally labelled with a difficulty. | ||
| That difficulty level is a best-guess by the dev-team how complex or evil an issue will be. | ||
| [Tell us](https://github.com/rubberduck-vba/Rubberduck/issues/new?assignees=&labels=thanks&template=thanks-.md&title=) how you found out about Rubberduck, share that story about an obscure bug you'd been chasing for years that a Rubberduck inspection just single-handedly pointed out in a minute. | ||
|
|
||
| If you're new to C#, we recommend you start with \[difficulty-01-duckling\]. The next step \[difficulty-02-ducky\] requires some knowledge about C#, but not so much about how Rubberduck works - 02/ducky issues usually make a good introduction to using Rubberduck's internal API. | ||
| We don't do any telemetry, so we don't know how our users are using Rubberduck. Tell us what your favorite features are, what features you're perhaps not using but wish you'd be able to find more information about. | ||
|
|
||
| Then there's \[difficulty-03-duck\] which requires a good handle on C# and how the components of Rubberduck play toghether. | ||
| And finally there's \[difficulty-04-quackhead\] for when you really want to bang your head against the wall. | ||
| They require both good knowledge of C# and a deep understanding of how not only Rubberduck, but also COM and well, the VBE, works. | ||
| --- | ||
|
|
||
| In addition to this, a few people have put together some helpful resources about how Rubberduck works internally and help contributors tell left from right in the ~250k Lines of Code. | ||
| ## Code Contributions | ||
|
|
||
| You can find their work in the [GitHub wiki](https://github.com/rubberduck-vba/Rubberduck/wiki). If something in there doesn't quite seem to match, it's probably because nobody got around to updating it yet. You're very welcome to **improve** the wiki by adding and correcting information. (see right above) | ||
| So you want to get your hands dirty and fix that obnoxious bug in the last release? Well that's great, we like seeing new faces in the fray 😄 Or you just want to find something that you can contribute to to learn C#? Or... Whatever your motivation is, if you're looking to add something new we recommend taking a look at issues that are labeled ; if you're looking to take down a known bug, you will want to pick from issues that are labeled with [](https://github.com/rubberduck-vba/Rubberduck/issues?q=is%3Aissue+is%3Aopen+label%3Abug). | ||
|
|
||
| In case this doesn't quite help you or the information you need hasn't been added to the wiki, you can **always** ask questions. | ||
| Please do so in the ["War room"](https://chat.stackexchange.com/rooms/14929). | ||
| Note that you will need an account on any of the Stack Exchange sites with at least 20 reputation points to ask questions there. | ||
| Other than that, you can also open an issue with the label \[support\], but it may take longer to get back to that. | ||
| Rubberduck is intimidatingly large project, even for long-time contributors. When an issue is deemed fairly simple to fix or implement, we label it with , ...or with increasing but always very subjective difficulty/complexity levels up to | ||
|  if you dare. | ||
|
|
||
| In that room the core team talks about the duck and whatever else comes up. | ||
| N.B.: The rules of the Stack Exchange Network apply to everything you say in that room. But basically those are the same rules as those in the [CoC](#Code_of_Conduct). | ||
| Level 3 and above demand a deeper knowledge of the inner workings of VBA (or VB6), the VBIDE, and Rubberduck's internal APIs - and we're always happy to help a contributor gain that knowledge! | ||
|
|
||
| Whether you create an issue or a pull request, please avoid using `[` square brackets `]` in the title, and try to be as descriptive (but succinct) as possible. Square brackets in titles confuse our chat-bot, and end up rendering in weird broken ways in SE chat. Avoid riddles, bad puns and other would-be funny (or NSFW) titles that don't really *describe the issue or PR*. | ||
| We use GitHub's _Pull Request_ (PR) mechanism to share our work, so the first thing to do is to [fork the repository](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-forks) and then [cloning](https://docs.github.com/en/github/getting-started-with-github/about-remote-repositories#cloning-with-https-urls) it to your local machine. | ||
|
|
||
| ### Translations | ||
| Once you have a local copy of the repository, use Git commands (or GitHub tooling in Visual Studio) to [commit](https://docs.github.com/en/github/getting-started-with-github/github-glossary#commit) your local changes, then [push](https://docs.github.com/en/github/getting-started-with-github/github-glossary#push) your local branch to your GitHub fork, and from there you can use GitHub to create your PR. | ||
|
|
||
| Rubberduck is localized in multiple languages. | ||
| All these translations have been provided by volunteers. | ||
| We welcome both new translations as well as improvements to current translations very much. | ||
| When you start work on an existing issue, comment on that issue to let us know you're on it and a pull request will be incoming as a result: don't hesitate to ask any questions you need answered to keep progressing, "issue" pages _exist_ for that type of discussion! | ||
|
|
||
| The resource files are RESX/XML files easily editable in any text editor, but our recommendation goes to the [ResXManager](https://marketplace.visualstudio.com/items?itemName=TomEnglert.ResXManager) Visual Studio plug-in: | ||
| ### Translations & Resources | ||
|
|
||
|  | ||
| Rubberduck doesn't speak your language? Get [ResX Manager](https://marketplace.visualstudio.com/items?itemName=TomEnglert.ResXManager) (available both as a Visual Studio plug-in and as a standalone application) and have it create all the necessary resource keys and help you navigate and track the many .resx files in the solution. | ||
|
|
||
| If you contribute a translation for a brand new previously unsupported language, please keep in touch with the dev team so that new resource keys can be translated when a new release is coming up; abandoned languages/translations will end up getting dropped. | ||
| > ⚠️ If you contribute a translation for a brand new previously unsupported language, please **keep in touch** with the dev team so that new resource keys can be translated when a new release is coming up; abandoned languages/translations **will** end up getting dropped. | ||
| ## What comes out of it for me? | ||
|
|
||
| Well... the eternal gratitude of all Rubberduck users for one :wink: | ||
| Aside from that, all contributors are explicitly listed by name (or alias) in the "About Rubberduck" window. | ||
| Pull requests that improve wordings and translations are always welcome, too! |
Oops, something went wrong.