Downgraded C# language to version 5.

Localised dialog.
Fixed formatting issues.

Author: rossknudsen

RetailCoder.VBE/Root/RubberduckModule.cs

@@ -68,7 +68,7 @@ public override void Load()
             Bind<RubberduckCommandBar>().ToSelf().InSingletonScope();
             Bind<TestExplorerModel>().ToSelf().InSingletonScope();
             Bind<IOperatingSystem>().To<WindowsOperatingSystem>().InSingletonScope();
-			Bind<RegisteredLibraryModelService>().To<RegisteredLibraryModelService>().InSingletonScope();
+            Bind<RegisteredLibraryModelService>().To<RegisteredLibraryModelService>().InSingletonScope();
 
             BindCodeInspectionTypes();
 
@@ -371,7 +371,7 @@ private IEnumerable<IMenuItem> GetRubberduckMenuItems()
                 Kernel.Get<SettingsCommandMenuItem>(),
                 Kernel.Get<InspectionResultsCommandMenuItem>(),
                 Kernel.Get<ShowSourceControlPanelCommandMenuItem>(),
-				Kernel.Get<ReferenceBrowserCommandMenuItem>(),
+                Kernel.Get<ReferenceBrowserCommandMenuItem>(),
                 GetUnitTestingParentMenu(),
                 GetSmartIndenterParentMenu(),
                 GetRefactoringsParentMenu(),

RetailCoder.VBE/Rubberduck.csproj

@@ -29,6 +29,7 @@
     <NoWarn>1591</NoWarn>
     <PlatformTarget>AnyCPU</PlatformTarget>
     <UseVSHostingProcess>true</UseVSHostingProcess>
+    <LangVersion>5</LangVersion>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>full</DebugType>

RetailCoder.VBE/UI/ReferenceBrowser/ReferenceBrowser.xaml

@@ -10,7 +10,7 @@
 
     <TabControl Padding="5">
 
-        <TabItem Header="COM">
+        <TabItem Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=ReferenceBrowser_COM}">
             <Grid>
                 <Grid.RowDefinitions>
                     <RowDefinition Height="Auto"/>
@@ -21,10 +21,9 @@
                     <ColumnDefinition />
                 </Grid.ColumnDefinitions>
 
-                <TextBlock Margin="5"
-                           Padding="5">
-                    Filter:
-                </TextBlock>
+                <TextBlock Text="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=ReferenceBrowser_Filter}"
+                           Margin="5"
+                           Padding="5" />
                 <TextBox Text="{Binding ComReferencesFilter, UpdateSourceTrigger=PropertyChanged}" 
                          HorizontalAlignment="Stretch"
                          Margin="5"
@@ -40,7 +39,7 @@
             </Grid>
         </TabItem>
 
-        <TabItem Header="VBA" >
+        <TabItem Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=ReferenceBrowser_VBA}" >
             <Grid>
                 <Grid.RowDefinitions>
                     <RowDefinition Height="Auto"/>
@@ -59,7 +58,7 @@
                         Grid.Row="0"
                         Margin="5"
                         Padding="5">
-                    Browse...
+                    <TextBlock Text="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=ReferenceBrowser_Browse}" />
                 </Button>
 
                 <local:ReferenceListControl DataContext="{Binding VbaProjectReferences}"

RetailCoder.VBE/UI/ReferenceBrowser/ReferenceBrowserViewModel.cs

@@ -26,16 +26,10 @@ public ReferenceBrowserViewModel(VBE vbe, RegisteredLibraryModelService service,
 
             _registeredComReferences = new ObservableCollection<RegisteredLibraryViewModel>();
             ComReferences = new CollectionViewSource {Source = _registeredComReferences}.View;
-            //ComReferences.DeferRefresh();
-            ComReferences.SortDescriptions.Add(
-                new SortDescription(nameof(RegisteredLibraryViewModel.CanRemoveReference),
-                ListSortDirection.Ascending));
-            ComReferences.SortDescriptions.Add(
-                new SortDescription(nameof(RegisteredLibraryViewModel.IsActiveProjectReference),
-                ListSortDirection.Descending));
-            ComReferences.SortDescriptions.Add(
-                new SortDescription(nameof(RegisteredLibraryViewModel.Name), 
-                ListSortDirection.Ascending));
+            //ComReferences.DeferRefresh();  would prefer to use this for performance but gives an error.
+            ComReferences.SortDescriptions.Add(new SortDescription("CanRemoveReference", ListSortDirection.Ascending));
+            ComReferences.SortDescriptions.Add(new SortDescription("IsActiveProjectReference", ListSortDirection.Descending));
+            ComReferences.SortDescriptions.Add(new SortDescription("Name", ListSortDirection.Ascending));
             //ComReferences.Refresh();
 
             _vbaProjectReferences = new ObservableCollection<RegisteredLibraryViewModel>();
@@ -47,9 +41,9 @@ public ReferenceBrowserViewModel(VBE vbe, RegisteredLibraryModelService service,
             AddVbaProjectReferenceCommand = new AddReferenceCommand(filePicker, AddVbaReference);
         }
 
-        public ICollectionView ComReferences { get; }
+        public ICollectionView ComReferences { get; private set; }
 
-        public ICollectionView VbaProjectReferences { get; }
+        public ICollectionView VbaProjectReferences { get; private set; }
 
         public string ComReferencesFilter
         {
@@ -121,7 +115,12 @@ private void CreateViewModelForVbaProjectReference(Reference reference)
 
         public void Dispose()
         {
-            (AddVbaProjectReferenceCommand as IDisposable)?.Dispose();
+
+            var command = AddVbaProjectReferenceCommand as IDisposable;
+            if (command != null)
+            {
+                command.Dispose();
+            }
             AddVbaProjectReferenceCommand = null;
         }
 
@@ -135,7 +134,7 @@ internal AddReferenceCommand(IOpenFileDialog filePicker, Action<string> addRefer
             {
                 if (addReferenceCallback == null)
                 {
-                    throw new ArgumentNullException(nameof(addReferenceCallback));
+                    throw new ArgumentNullException("addReferenceCallback");
                 }
                 _addReferenceCallback = addReferenceCallback;
                 _filePicker = filePicker;
@@ -158,7 +157,10 @@ protected override void ExecuteImpl(object parameter)
 
             public void Dispose()
             {
-                _filePicker?.Dispose();
+                if (_filePicker != null)
+                {
+                    _filePicker.Dispose();
+                }
                 _addReferenceCallback = null;
             }
         }

RetailCoder.VBE/UI/ReferenceBrowser/ReferenceListControl.xaml

@@ -27,7 +27,7 @@
                         </GridViewColumn.CellTemplate>
                     </GridViewColumn>
 
-                    <GridViewColumn Header="Name"
+                    <GridViewColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=Name}"
                                     Width="400">
                         <GridViewColumn.CellTemplate>
                             <DataTemplate DataType="local:RegisteredLibraryViewModel">
@@ -46,23 +46,26 @@
 
             <TextBlock Margin="0,5,0,0">
                 <TextBlock.Text>
-                    <MultiBinding StringFormat="Name: {0}">
+                    <MultiBinding StringFormat="\{0\}: \{1\}">
+                        <Binding Path="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=Name}" />
                         <Binding Path="Name" />
                     </MultiBinding>
                 </TextBlock.Text>
             </TextBlock>
 
             <TextBlock Margin="0,5,0,0">
                 <TextBlock.Text>
-                    <MultiBinding StringFormat="Path: {0}">
+                    <MultiBinding StringFormat="\{0\}: \{1\}">
+                        <Binding Path="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=Path}" />
                         <Binding Path="FilePath" />
                     </MultiBinding>
                 </TextBlock.Text>
             </TextBlock>
 
             <TextBlock Margin="0,5,0,5">
                 <TextBlock.Text>
-                    <MultiBinding StringFormat="Guid: {0}">
+                    <MultiBinding StringFormat="\{0\}: \{1\}">
+                        <Binding Path="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=Guid}" />
                         <Binding Path="Guid" />
                     </MultiBinding>
                 </TextBlock.Text>

RetailCoder.VBE/UI/ReferenceBrowser/RegisteredLibraryViewModel.cs

@@ -24,7 +24,7 @@ public RegisteredLibraryViewModel(VbaReferenceModel model, VBProject activeProje
             }
         }
 
-        public VbaReferenceModel Model { get; }
+        public VbaReferenceModel Model { get; private set; }
 
         public string FilePath
         {
@@ -42,7 +42,9 @@ public bool IsActiveProjectReference
             set
             {
                 if (value == _isActiveReference)
+                {
                     return;
+                }
 
                 if (value)
                 {
@@ -60,6 +62,7 @@ public bool IsActiveProjectReference
                     else
                     {
                         // TODO warn the user that they cannot remove this reference.
+                        // The user shouldn't be able to remove a builtin reference anyway.
                     }
                 }
                 OnPropertyChanged();
@@ -97,7 +100,6 @@ public short MajorVersion
 
         private void AddReferenceToActiveProject()
         {
-            //_activeProject.References.AddFromGuid(Guid.ToString("B"), MajorVersion, MinorVersion);
             _activeProject.References.AddFromFile(FilePath);
         }
 
@@ -124,17 +126,9 @@ private bool RemoveReferenceFromActiveProject()
 
         private bool GetIsActiveProjectReference()
         {
-            //return GetActiveProjectReferenceByGuid(Guid) != null;
             return GetActiveProjectReferenceByFilePath(FilePath) != null;
         }
 
-        private Reference GetActiveProjectReferenceByGuid(Guid guid)
-        {
-            return _activeProject.References
-                .OfType<Reference>()
-                .SingleOrDefault(r => Guid.Parse(r.Guid) == guid);
-        }
-
         private Reference GetActiveProjectReferenceByFilePath(string filePath)
         {
             return _activeProject.References

RetailCoder.VBE/UI/RubberduckUI.Designer.cs

@@ -1736,4 +1736,25 @@ All our stargazers, likers & followers, for the warm fuzzies
   <data name="ReferenceBrowser_Menu" xml:space="preserve">
     <value>Reference Browser</value>
   </data>
+  <data name="Filter" xml:space="preserve">
+    <value>Filter</value>
+  </data>
+  <data name="Guid" xml:space="preserve">
+    <value>GUID</value>
+  </data>
+  <data name="Path" xml:space="preserve">
+    <value>Path</value>
+  </data>
+  <data name="ReferenceBrowser_Browse" xml:space="preserve">
+    <value>Browse...</value>
+  </data>
+  <data name="ReferenceBrowser_COM" xml:space="preserve">
+    <value>COM</value>
+  </data>
+  <data name="ReferenceBrowser_Filter" xml:space="preserve">
+    <value>Filter:</value>
+  </data>
+  <data name="ReferenceBrowser_VBA" xml:space="preserve">
+    <value>VBA</value>
+  </data>
 </root>