Changed Debug.Assert killing the inspection in presence of annotation into a conditional return false

MDoerner · MDoerner · commit 56cd0f8ec7a9 · 2017-06-23T00:40:32.000+02:00
diff --git a/Rubberduck.Parsing/VBA/Attributes.cs b/Rubberduck.Parsing/VBA/Attributes.cs
@@ -80,7 +80,11 @@ public class Attributes : HashSet<AttributeNode>
     {
         public bool HasAttributeFor(AnnotationType annotationType, string memberName = null)
         {
-            Debug.Assert(annotationType.HasFlag(AnnotationType.Attribute));
+            if (!annotationType.HasFlag(AnnotationType.Attribute))
+            {
+                return false;
+            }
+
             var name = "VB_" + annotationType;
 
             if (annotationType.HasFlag(AnnotationType.MemberAnnotation))

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,11 @@ public class Attributes : HashSet<AttributeNode>`
`80`	`80`	`{`
`81`	`81`	`public bool HasAttributeFor(AnnotationType annotationType, string memberName = null)`
`82`	`82`	`{`
`83`		`- Debug.Assert(annotationType.HasFlag(AnnotationType.Attribute));`
	`83`	`+ if (!annotationType.HasFlag(AnnotationType.Attribute))`
	`84`	`+ {`
	`85`	`+ return false;`
	`86`	`+ }`
	`87`	`+`
`84`	`88`	`var name = "VB_" + annotationType;`
`85`	`89`
`86`	`90`	`if (annotationType.HasFlag(AnnotationType.MemberAnnotation))`